Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue #189 #231

Merged
merged 1 commit into from Nov 16, 2019
Merged

Fixing issue #189 #231

merged 1 commit into from Nov 16, 2019

Conversation

@cagomezr
Copy link
Collaborator

cagomezr commented Nov 15, 2019

Fixing issue #189

On mobile views we have the following issues:

  • The buttons when tested with poor vision individuals I got feed back that they should be sligthly larger so I updated the font size, by a 40% ratio.
  • On our close functionality we have an issue with the system where when we close on devices of small range and strange screen targets ( Asus Zenfone 2 and iPhone 4 tested) the close menu function didn't react , the solution was to increasing the close "x" to a rate of 75%

this changes can be seen prototype in

https://cagomezr.github.io/telescope-demo/

This pull request was done as the rebasing was having issues and having very very strange results.

Fixing issue #189

On mobile views we have the following issues:

    The buttons when tested with poor vision individuals I got feed back that they should be sligthly larger so I updated the font size, by a 40% ratio.

    On our close functionality we have an issue with the system where when we close on devices of small range and strange screen targets ( Asus Zenfone 2 and iPhone 4 tested) the close menu function didn't react , the solution was to increasing the close "x" to a rate of 75%

this changes can be seen prototype in

https://cagomezr.github.io/telescope-demo/
@humphd
humphd approved these changes Nov 16, 2019
Copy link
Contributor

humphd left a comment

Excellent. Thanks for redoing this.

@humphd humphd merged commit 8c82ae2 into master Nov 16, 2019
3 checks passed
3 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@humphd humphd deleted the issue189-2 branch Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.