Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #91: created a login page for SAML testing #234

Merged
merged 4 commits into from Nov 16, 2019

Conversation

@agarcia-caicedo
Copy link
Collaborator

agarcia-caicedo commented Nov 16, 2019

Created a simple html login page for SAML testing purposes

@Grommers00

This comment has been minimized.

Copy link
Collaborator

Grommers00 commented Nov 16, 2019

Looks good - very simple clean code, hopefully we can eventually add in more to use this as the base for our tests regarding saml2. This may need to be updated later it looks like to reflect seneca's redirect page.

Copy link
Collaborator

Grommers00 left a comment

Looks good - this may need to be updated as we progress through SAML2 but great start!

src/login/login.html Show resolved Hide resolved
src/login/login.html Show resolved Hide resolved
@neilong31

This comment has been minimized.

Copy link
Collaborator

neilong31 commented Nov 16, 2019

It looks good tho and shouldn't break anything :)

@agarcia-caicedo agarcia-caicedo dismissed stale reviews from neilong31 and Grommers00 via ba05875 Nov 16, 2019
@agarcia-caicedo agarcia-caicedo requested review from neilong31 and Grommers00 Nov 16, 2019
Copy link
Collaborator

Grommers00 left a comment

Looks good, great idea to add the comments

Copy link
Collaborator

neilong31 left a comment

Nice! Looks good and the comments are concise and understandable

@neilong31 neilong31 merged commit bd07be3 into Seneca-CDOT:master Nov 16, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.