Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #233 - add grid system #235

Closed
wants to merge 1 commit into from
Closed

Conversation

@cyh0968
Copy link

cyh0968 commented Nov 16, 2019

I added normalize.css grid.css, and I added box-sizing:

border-box since it makes easier to control.
Using normalize makes browsers render more consistently.

@@ -0,0 +1,689 @@

/* SECTIONS ============================================================================= */

This comment has been minimized.

Copy link
@humphd

humphd Nov 16, 2019

Contributor

Where is this code from? Did you write all this from scratch? If not, we need a license.

This comment has been minimized.

Copy link
@cyh0968

cyh0968 Nov 16, 2019

Author

I'm not sure about the license. The code is from http://www.responsivegridsystem.com/
image

Under the Creative Commons Attribution 3.0 License. If this license may cause an issue, I will replace the code with the bootstrap CDN link.

Unfortunately, the responsive grid system does not support the CDN link.

@@ -7,19 +7,23 @@
<meta http-equiv="X-UA-Compatible" content="ie=edge">
<title>Telescope | Tracking Blogs in Orbit</title>
<!-- CSS -->
<link rel="stylesheet" href="./style\normalize.css">

This comment has been minimized.

Copy link
@humphd

humphd Nov 16, 2019

Contributor

Can we not use CDN links?

This comment has been minimized.

Copy link
@cyh0968

cyh0968 Nov 16, 2019

Author

I updated it to the CDN link.

Yohan Choi
@cyh0968 cyh0968 force-pushed the cyh0968:issue#233 branch from 8e8d7e9 to 528f7b8 Nov 16, 2019
@humphd

This comment has been minimized.

Copy link
Contributor

humphd commented Nov 16, 2019

Why not just use CSS Grid? It's all baked into browsers now: https://css-tricks.com/snippets/css/complete-guide-grid/

@humphd

This comment has been minimized.

Copy link
Contributor

humphd commented Nov 20, 2019

@cyh0968 I'm going to close this for now, and get you to do a new PR on just adding the normalize.css. Do that as a CDN link in the frontend index file, and do it in a new branch off current master. Let's leave the grid out until we have code that needs it, and then, try to use more modern options.

@humphd humphd closed this Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.