Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #73- Updated readme #236

Merged
merged 11 commits into from Nov 16, 2019
Merged

Fix #73- Updated readme #236

merged 11 commits into from Nov 16, 2019

Conversation

MusaBajwa
Copy link
Contributor

Updated Readme file.

@MusaBajwa MusaBajwa changed the title Fix Issue 73- Updated readme Fix #Issue 73- Updated readme Nov 16, 2019
@MusaBajwa MusaBajwa changed the title Fix #Issue 73- Updated readme Fix #73- Updated readme Nov 16, 2019
@Grommers00 Grommers00 self-assigned this Nov 16, 2019
Copy link
Contributor

@Manan311 Manan311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should still include the contribution link to the contribution file in this file like how we have it set up right now.

Grommers00
Grommers00 previously approved these changes Nov 16, 2019
Copy link
Contributor

@Grommers00 Grommers00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read through the documentation, looks good on my end!

@MusaBajwa
Copy link
Contributor Author

Just added the contribution link.

@MusaBajwa MusaBajwa dismissed Manan311’s stale review November 16, 2019 02:32

Added recommended changes

@dbeigi dbeigi self-requested a review November 16, 2019 02:47
dbeigi
dbeigi previously approved these changes Nov 16, 2019
Copy link
Contributor

@dbeigi dbeigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read through the document, looks good so far to me!

@MusaBajwa MusaBajwa dismissed stale reviews from dbeigi and Grommers00 via f48d706 November 16, 2019 05:03
@MusaBajwa MusaBajwa closed this Nov 16, 2019
@MusaBajwa MusaBajwa reopened this Nov 16, 2019
@eekbatani eekbatani self-requested a review November 16, 2019 05:21
Copy link
Contributor

@eekbatani eekbatani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read through it, everything looks clean grammatical and syntactically to me.

@dbeigi dbeigi self-requested a review November 16, 2019 05:29
@MusaBajwa MusaBajwa merged commit 63bad39 into Seneca-CDOT:master Nov 16, 2019
@MusaBajwa MusaBajwa deleted the issue-73 branch November 16, 2019 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants