Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commit link to latest contribution #2518

Merged
merged 1 commit into from Nov 23, 2021

Conversation

Kevan-Y
Copy link
Contributor

@Kevan-Y Kevan-Y commented Nov 23, 2021

Issue This PR Addresses

Fixes #2506

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

Format:

(avatar) Luigi Zaccagnini 2dc6a97

image

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@Kevan-Y Kevan-Y requested a review from humphd November 23, 2021 22:18
@gitpod-io
Copy link

gitpod-io bot commented Nov 23, 2021

@humphd
Copy link
Contributor

humphd commented Nov 23, 2021

Can we do something to set the SHA off from the name a bit more? Here is how GitHub does it:

Screen Shot 2021-11-23 at 5 23 43 PM

In other words: monospaced type 'code' font, clickable, in blue.

@Kevan-Y
Copy link
Contributor Author

Kevan-Y commented Nov 23, 2021

Can we do something to set the SHA off from the name a bit more? Here is how GitHub does it:

Screen Shot 2021-11-23 at 5 23 43 PM

In other words: monospaced type 'code' font, clickable, in blue.

Is this enough, change to monospaced, used .text-xs , and .btn-link class
image

@humphd
Copy link
Contributor

humphd commented Nov 23, 2021

Yeah, that's a lot better.

Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on GitPod, works well (nice touch that @Kevan-Y is the latest contributor!):

Screen Shot 2021-11-23 at 6 35 35 PM

Copy link
Contributor

@Andrewnt219 Andrewnt219 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Tested locally.

@humphd
Copy link
Contributor

humphd commented Nov 23, 2021

@Kevan-Y go ahead and merge this yourself.

@Kevan-Y Kevan-Y merged commit 9e57e03 into Seneca-CDOT:master Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link to latest contribution
3 participants