Don't link local package #3247
Merged
Don't link local package #3247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
humphd
approved these changes
Mar 17, 2022
|
Comment for others reading this PR: we are going to move to using npm registry packages of things like satellite and our eslint config vs. linking in the workspace. In order to get a new version of these published, update their |
TueeNguyen
approved these changes
Mar 17, 2022
|
I guess that means we should prioritize getting ESLint fixes in so we can push a release. I'm getting sick of these ESLint errors :( |
8 tasks
|
@cindyledev, yeah it's not ideal, I'm re-configuring eslint, I think the current config is a bit off |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've made the decision to not link local packages, both Satellite and Eslint.