Fixes #264: Store Posts into Redis #411
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humphd
requested changes
Dec 3, 2019
|
|
||
| exports.workerCallback = async function(job) { | ||
| const { url } = job.data; | ||
| const posts = await feedparser(url); |
There was a problem hiding this comment.
Can you rebase on master please? We have updated the way this workerCallback does its thing.
src/backend/feed/worker.js
Outdated
| }; | ||
|
|
||
| // eslint-disable-next-line prettier/prettier |
There was a problem hiding this comment.
ESLint was complaining about an issue with function () and prettier kept doing changing my code which I had written function() to function ()
| feedQueue.process(this.workerCallback); | ||
| feedQueue.process(exports.workerCallback); | ||
| feedQueue.on('completed', (job, results) => { | ||
| if (results.length > 0) { |
There was a problem hiding this comment.
Is this necessary? If it's 0, won't it just never call the forEach callback? I'd remove it.
src/backend/feed/worker.js
Outdated
| if (results.length > 0) { | ||
| results.forEach(result => { | ||
| console.log(`Result: ${result.title}`); | ||
| // We have an issure here, addPost is an async function. Should we make the start |
There was a problem hiding this comment.
Yes, we also need to update how you do this "loop" when you have promises for each:
await Promise.all(results.map(async result => storate.addPost(result)))And yeah, we should probably make start async.
|
Fixed and merged in class. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is still a WIP and builds on top of the work done for storage.js.
feedParserconst processedPostOn completion of the processing, it should then store each individual post(result) into Redis by using
storage.addPost(). There's something we may have to look at though as storage.addPost is an async function. Should we make the exports.start function an async function so we can use await?