Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some rules to '.eslintrc.js' #68

Merged
merged 3 commits into from Nov 7, 2019

Conversation

manekenpix
Copy link
Member

Added some rules to .eslintrc.js that I think would be useful.

@manekenpix manekenpix added the type: enhancement New feature or request label Nov 7, 2019
@manekenpix manekenpix added this to In progress/Review in Main via automation Nov 7, 2019
"jest": true,
},
rules: {
"no-console": "off",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: why "off" vs. 0, which you use below?

Also, since this is a .js file, we can include comments, so would you mind adding a comment above each of these new rules explaining what you're doing here? That way others can discover what this is all about.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For no-console, I used what eslint uses in their examples here, and when I was testing func-names lint complained and wanted me to use 0. I can test if no-console works with 0 or if func-names works with off to have more consistency.

Also, I didn't add any comments because all the info to read about these changes is included in the description of the PR. Should I still add it to the js file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it and now they all use off.

@manekenpix
Copy link
Member Author

I added some comments to eslintrc.jsfor clarification.

Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is better, thank you. I think having the extra comments above will help people work more quickly, since they won't have to go read the entire doc. Thanks.

@MusaBajwa MusaBajwa merged commit f66921d into Seneca-CDOT:master Nov 7, 2019
Main automation moved this from In progress/Review to Done Nov 7, 2019
@manekenpix manekenpix deleted the add-rules-to-eslint branch November 7, 2019 16:00
DukeManh pushed a commit to DukeManh/telescope that referenced this pull request Mar 7, 2022
chore(deps): update dependency eslint to v8.10.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
No open projects
Main
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants