Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed linting errors #76

Merged
merged 1 commit into from Nov 7, 2019
Merged

Conversation

@manekenpix
Copy link
Collaborator

manekenpix commented Nov 7, 2019

After merging #49 a lot of linting errors were introduced.
This fixes those errors.
Let's make sure we rebase and run the test before committing and/or submitting PR

@manekenpix manekenpix changed the title Fixed linter errors Fixed linting errors Nov 7, 2019
@aprilllllllll

This comment has been minimized.

Copy link
Contributor

aprilllllllll commented Nov 7, 2019

Might because I change in the file in Github after having conflict.
Thank you!

Copy link
Collaborator

ImmutableBox left a comment

Yup. ESLint did it's job. Good work 👍 .

@manekenpix manekenpix merged commit c57c1e2 into Seneca-CDOT:master Nov 7, 2019
@manekenpix manekenpix deleted the manekenpix:fixed-linter-errors branch Nov 7, 2019
@Reza-Rajabi Reza-Rajabi added this to Done in Main Nov 7, 2019
@Reza-Rajabi Reza-Rajabi added the on-board label Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Main
Done
4 participants
You can’t perform that action at this time.