Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #73 adding license to readme.md and linux to contributing.md #99

Closed
wants to merge 5 commits into from

Conversation

@cindyledev
Copy link
Collaborator

cindyledev commented Nov 7, 2019

Added license section to the README.md file and provided solutions to some common errors I encountered setting up telescope in a Linux environment in the CONTRIBUTING.md file. I also added Git as a prerequisite for environment set up section. Git not required to actually run the software but it's required to contribute to this project. This references issue #73 but don't close the issue because @MusaBajwa is also working on it.

Copy link
Collaborator

lucacataldo left a comment

Helpful comments & changes, looks good!

ODAVING and others added 4 commits Nov 8, 2019
CSS/HTML/JS updates for optimization of static webpage

Fixes #61

enhancement (folders): Front-End Folder made
Enhancement (HTML/jS): modified the website
@cindyledev cindyledev requested a review from lucacataldo Nov 8, 2019
@Reza-Rajabi Reza-Rajabi added the on-board label Nov 9, 2019
@Reza-Rajabi Reza-Rajabi added this to In progress/Review in Main via automation Nov 9, 2019
@@ -10,13 +10,15 @@ Before creating an issue:
* If they are, reach out and try to help.

## Pull Requests
Please submit pull requests in response to open issues. If you have a bug or feature, bring it up in issues first, to avoid two or more people working on the same thing.
Please submit pull requests in response to open issues. If you have a bug or feature, bring it up in issues first, to avoid two or more people working on the same thing. Remember to rebase and run `npm run pretest` before submitting a pull request.

This comment has been minimized.

Copy link
@manekenpix

manekenpix Nov 9, 2019

Collaborator

I'm not sure if this is the right place to mention rebasing and runnig tests.
There's another section in this document called THE LIST OF THINGS THAT MUST BE DONE BY A CONTRIBUTOR BEFORE FILLING A PR. Maybe that's the appropriate place. Also, it's better to run test, not pretest, since the pretest is included in the test.

@@ -27,10 +29,28 @@ Some helpful guides:
An easier solution would be to use Docker.

**Setup**
1. Clone the repository with `git clone https://github.com/Seneca-CDOT/telescope.git`

This comment has been minimized.

Copy link
@manekenpix

manekenpix Nov 9, 2019

Collaborator

This should include cloning using ssh or no reference to https or ssh at all.

cindy 2570 0.0 0.0 253100 4908 pts/1 Sl+ 13:11 0:00 redis-server *:6379
cindy 2588 0.0 0.0 215744 888 pts/0 S+ 13:16 0:00 grep --color=auto redis
```
Run `sudo kill -9 2570`

This comment has been minimized.

Copy link
@manekenpix

manekenpix Nov 9, 2019

Collaborator

This part is a bit confusing, I think it'd be better to test if the service is running (sudo systemctl status redis) before trying to stop it (sudo systemctl stop redis). Also, you can delete your user name from the example.

@manekenpix

This comment has been minimized.

Copy link
Collaborator

manekenpix commented Nov 9, 2019

Also, there seems to be a conflict. You might need to rebase.

@cindyledev cindyledev closed this Nov 9, 2019
@cindyledev cindyledev deleted the cindyledev:issue-73 branch Nov 9, 2019
Main automation moved this from In progress/Review to Closed Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Main
Closed
6 participants
You can’t perform that action at this time.