Skip to content

Add additional_temperatures feature#157

Closed
Smankusors wants to merge 1 commit intoSennevds:masterfrom
Smankusors:master
Closed

Add additional_temperatures feature#157
Smankusors wants to merge 1 commit intoSennevds:masterfrom
Smankusors:master

Conversation

@Smankusors
Copy link
Contributor

@Smankusors Smankusors commented Apr 29, 2023

Note

edit: I closed this because the branch name doesn't make sense (I already did this yesteryear and I forgot)
And this PR is stalled for too long I think, also there is a lack of documentation, so I will figure it later...

mostly I copy pasted from external drives sensors logics 😅

I needed this because my Rock Pi 4 has a cpu sensor name. While I think that could be as simple as adding it to the whitelist, I have a plan to buy a different SBCs, that might also have different sensor name...
Also, I want to install this on several Android devices, because I want to track their battery temperatures

btw, other changes:

  • remove old comment about the old way of reading temperature
    (git already has history for this, so we don't need it anymore?)
  • refactor the sensor enabled checking on a separate function
  • refactor get_temp so that it can read other temperatures

let me know if you need anything else 😉

@Smankusors Smankusors deleted the branch Sennevds:master April 30, 2023 17:04
@Smankusors Smankusors closed this Apr 30, 2023
@Smankusors Smankusors deleted the master branch April 30, 2023 17:04
@Smankusors Smankusors restored the master branch April 30, 2023 17:04
@Smankusors Smankusors deleted the master branch April 30, 2023 17:05
@Smankusors Smankusors restored the master branch April 30, 2023 17:05
@Smankusors Smankusors reopened this Apr 30, 2023
@Smankusors Smankusors deleted the branch Sennevds:master April 1, 2024 14:31
@Smankusors Smankusors closed this Apr 1, 2024
@Smankusors Smankusors deleted the master branch April 1, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant