Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uppercase site URL #311

Closed
tusmester opened this issue Mar 13, 2018 · 5 comments
Closed

Uppercase site URL #311

tusmester opened this issue Mar 13, 2018 · 5 comments
Labels
bug
Milestone

Comments

@tusmester
Copy link
Member

@tusmester tusmester commented Mar 13, 2018

It is not possible to assign a url containing uppercase letters to a sensenet site (for example www.SomeTestUrl.com).

The problem is most likely in the Site.IsValidSiteUrl method: the uri.Authority property check fails in this case.

  • fix and notify TC
  • add a test
@atomanonymous

This comment has been minimized.

Copy link

@atomanonymous atomanonymous commented Oct 4, 2019

I'll work on this!

@atomanonymous

This comment has been minimized.

Copy link

@atomanonymous atomanonymous commented Oct 4, 2019

some help needed here where do i find the particular file?

@tusmester

This comment has been minimized.

Copy link
Member Author

@tusmester tusmester commented Oct 4, 2019

@atomanonymous

private bool IsValidSiteUrl(string url)

ThiagoWhispher added a commit to ThiagoWhispher/sensenet that referenced this issue Oct 5, 2019
atomanonymous added a commit to atomanonymous/sensenet that referenced this issue Oct 5, 2019
atomanonymous added a commit to atomanonymous/sensenet that referenced this issue Oct 5, 2019
Assigned to lower case issue SenseNet#311
tusmester added a commit that referenced this issue Oct 11, 2019
Fix #311
@berry120

This comment has been minimized.

Copy link

@berry120 berry120 commented Oct 12, 2019

Hello, notice this one is unassigned, but looks like it may be complete already (or is there still more work to do here?) If so I'd be interested, but no worries if not!

@B3zo0

This comment has been minimized.

Copy link
Member

@B3zo0 B3zo0 commented Oct 12, 2019

Hi @berry120 this is already fixed in #693 . We usually close issues that are released and this is not yet released.

@herflis herflis added this to the Sprint 198 milestone Dec 3, 2019
@herflis herflis modified the milestones: Sprint 198, Sprint 199 Dec 5, 2019
@herflis herflis modified the milestones: Sprint 199, Sprint 200 Jan 6, 2020
@tusmester tusmester removed their assignment Jan 6, 2020
@tusmester tusmester closed this in a101907 Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.