Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redux Store typings cleanup #101

Merged
merged 12 commits into from Feb 8, 2019

Conversation

Projects
None yet
2 participants
@gallayl
Copy link
Contributor

gallayl commented Feb 1, 2019

  • updated redux-di-middleware to 3.0.0
  • simplified type definitions

@gallayl gallayl self-assigned this Feb 1, 2019

@gallayl gallayl changed the title [KFI]chore(packages): updated redux-di-middleware to 3.0.0 Redux Store typings cleanup Feb 1, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 1, 2019

Codecov Report

Merging #101 into develop will increase coverage by 0.01%.
The diff coverage is 63.63%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #101      +/-   ##
===========================================
+ Coverage    87.12%   87.13%   +0.01%     
===========================================
  Files          104      104              
  Lines         3130     3125       -5     
  Branches       736      735       -1     
===========================================
- Hits          2727     2723       -4     
+ Misses         403      402       -1
Impacted Files Coverage Δ
...ent-viewer-react/src/components/DocumentViewer.tsx 86.84% <ø> (ø) ⬆️
...s/sn-document-viewer-react/src/components/Page.tsx 73.33% <ø> (ø) ⬆️
.../src/ContentList/CellTemplates/DisplayNameCell.tsx 100% <100%> (ø) ⬆️
...search-react/src/Components/Fields/PresetField.tsx 100% <100%> (ø) ⬆️
...n-document-viewer-react/src/store/PreviewImages.ts 31.34% <50%> (-3.87%) ⬇️
...ges/sn-document-viewer-react/src/store/Document.ts 26.04% <50%> (-0.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19ffcd1...4eae44d. Read the comment docs.

@gallayl gallayl requested review from B3zo0 and herflis Feb 1, 2019

gallayl and others added some commits Feb 1, 2019

@B3zo0
Copy link
Member

B3zo0 left a comment

Nice 👍

chore(sn-dms-demo):Apply suggestions from code review
Co-Authored-By: gallayl <gallayl@users.noreply.github.com>
@B3zo0

B3zo0 approved these changes Feb 6, 2019

@gallayl gallayl merged commit 08da98a into develop Feb 8, 2019

5 of 6 checks passed

codecov/patch 63.63% of diff hit (target 87.12%)
Details
codecov/project 87.13% (+0.01%) compared to 19ffcd1
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
license/cla Contributor License Agreement is signed.
Details

@gallayl gallayl deleted the refactor/redux-store-cleanup branch Feb 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.