Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/pickers react #103

Merged
merged 37 commits into from Feb 18, 2019
Merged

Feature/pickers react #103

merged 37 commits into from Feb 18, 2019

Conversation

zoltanbedi
Copy link
Contributor

Pickers react package with list picker component

@codecov
Copy link

codecov bot commented Feb 4, 2019

Codecov Report

Merging #103 into develop will decrease coverage by 0.98%.
The diff coverage is 36.06%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #103      +/-   ##
===========================================
- Coverage    87.15%   86.17%   -0.99%     
===========================================
  Files          106      109       +3     
  Lines         3129     3189      +60     
  Branches       737      757      +20     
===========================================
+ Hits          2727     2748      +21     
- Misses         402      441      +39
Impacted Files Coverage Δ
packages/sn-pickers-react/src/ListPicker/Item.tsx 100% <100%> (ø)
packages/sn-pickers-react/src/ListPicker/index.tsx 100% <100%> (ø)
...eact/src/ContentList/CellTemplates/ActionsCell.tsx 100% <100%> (ø) ⬆️
...ges/sn-pickers-react/src/ListPicker/ListPicker.tsx 18.75% <18.75%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6d356f...4f13275. Read the comment docs.

@gallayl gallayl self-requested a review February 6, 2019 14:17
examples/sn-react-component-docs/package.json Outdated Show resolved Hide resolved
examples/sn-react-component-docs/package.json Outdated Show resolved Hide resolved
packages/sn-pickers-react/src/ListPicker/Item.tsx Outdated Show resolved Hide resolved
packages/sn-pickers-react/src/ListPicker/Item.tsx Outdated Show resolved Hide resolved
@zoltanbedi zoltanbedi merged commit 073bcb7 into develop Feb 18, 2019
@zoltanbedi zoltanbedi deleted the feature/pickers-react branch February 18, 2019 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants