Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/pickers react #103

Merged
merged 37 commits into from Feb 18, 2019

Conversation

Projects
None yet
3 participants
@B3zo0
Copy link
Member

B3zo0 commented Feb 4, 2019

Pickers react package with list picker component

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 4, 2019

Codecov Report

Merging #103 into develop will decrease coverage by 0.98%.
The diff coverage is 36.06%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #103      +/-   ##
===========================================
- Coverage    87.15%   86.17%   -0.99%     
===========================================
  Files          106      109       +3     
  Lines         3129     3189      +60     
  Branches       737      757      +20     
===========================================
+ Hits          2727     2748      +21     
- Misses         402      441      +39
Impacted Files Coverage Δ
packages/sn-pickers-react/src/ListPicker/Item.tsx 100% <100%> (ø)
packages/sn-pickers-react/src/ListPicker/index.tsx 100% <100%> (ø)
...eact/src/ContentList/CellTemplates/ActionsCell.tsx 100% <100%> (ø) ⬆️
...ges/sn-pickers-react/src/ListPicker/ListPicker.tsx 18.75% <18.75%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6d356f...4f13275. Read the comment docs.

B3zo0 added some commits Feb 4, 2019

@gallayl gallayl self-requested a review Feb 6, 2019

B3zo0 added some commits Feb 7, 2019

[KFI]refactor(pickers-react): simplified item component props
Merged Item type with ItemComponentProps
[KFI]refactor(dms-demo): pickers to use listpicker component
Removed backlink from picker base
 Used listpicker in pathpicker

@B3zo0 B3zo0 requested a review from herflis Feb 13, 2019

@B3zo0 B3zo0 merged commit 073bcb7 into develop Feb 18, 2019

3 of 6 checks passed

codecov/patch 36.06% of diff hit (target 87.15%)
Details
codecov/project 86.17% (-0.99%) compared to f6d356f
Details
deploy/netlify Deploy preview failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@B3zo0 B3zo0 deleted the feature/pickers-react branch Feb 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.