Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

range timestamps are strings #12

Closed
brandly opened this issue May 14, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@brandly
Copy link
Member

commented May 14, 2019

js-sentenai/src/api.js

Lines 330 to 339 in da8fabd

range (stream, start, end) {
const esc = encodeURIComponent;
const url = `/streams/${stream()}/start/${esc(start.toISOString())}/end/${esc(end.toISOString())}`;
return this.fetch(url).then(res => {
handleStatusCode(res);
return res.text();
}).then(text =>
text.split('\n').map(line => JSON.parse(line))
);
}

range(stream: Stream, start: Date, end: Date) : Promise<Item[]>

type Item = {
  id: string
  ts: string
  event: object
}

ts should be a Date instead

@brandly brandly closed this in 302f859 May 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.