Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

join URL components #13

Open
brandly opened this issue Jul 11, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@brandly
Copy link
Member

commented Jul 11, 2019

right now, we simply concatenate strings with the provided host. we assume the host doesn't have a trailing /, which can cause problems.

some code exists to handle this, but they seem to be concerned with a wide range of edge cases that i don't think we have. maybe we just strip trailing slashes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.