Skip to content

Mra/feat launcher#3

Merged
Mael-RABOT merged 15 commits into
masterfrom
mra/feat-launcher
May 31, 2026
Merged

Mra/feat launcher#3
Mael-RABOT merged 15 commits into
masterfrom
mra/feat-launcher

Conversation

@Mael-RABOT

Copy link
Copy Markdown
Contributor
image

Signed-off-by: Mael-RABOT <mael.rabot@gmail.com>
Signed-off-by: Mael-RABOT <mael.rabot@gmail.com>
Signed-off-by: Mael-RABOT <mael.rabot@gmail.com>
Signed-off-by: Mael-RABOT <mael.rabot@gmail.com>
Signed-off-by: Mael-RABOT <mael.rabot@gmail.com>
Signed-off-by: Mael-RABOT <mael.rabot@gmail.com>
@Mael-RABOT Mael-RABOT self-assigned this May 27, 2026
Comment thread install.sh

@charlesmadjeri charlesmadjeri left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

Comment thread launch_lucy.sh
@Mael-RABOT Mael-RABOT marked this pull request as draft May 27, 2026 12:27
Signed-off-by: Mael-RABOT <mael.rabot@gmail.com>
win supported though git bash & WSL as fallback

Signed-off-by: Mael-RABOT <mael.rabot@gmail.com>
Signed-off-by: Mael-RABOT <mael.rabot@gmail.com>
Signed-off-by: Mael-RABOT <mael.rabot@gmail.com>
m-brl
m-brl previously approved these changes May 28, 2026
Signed-off-by: Mael-RABOT <mael.rabot@epitech.eu>
@Mael-RABOT Mael-RABOT requested a review from m-brl May 28, 2026 09:05
@Mael-RABOT Mael-RABOT marked this pull request as ready for review May 28, 2026 09:05

@charlesmadjeri charlesmadjeri left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1:Ticking Developer mode or not does not change the launch, we have the same launch menu
Developer mode should be unticked by default when env is not set or not DEV=true, and be ticked by default when env is set to DEV=true, developer mode should also be the last element of the list, and separated by a blank line for install/build/launch.

This way the "default" user flow will be straightforward

2: After a run from TUI of target "Install", we got as output:

Install complete. Run ./launch_lucy.sh to start the stack.
--- Command finished with exit code 0 ---
Press Enter to exit.

Instead of prompting for re-run and exit, can we just prompt:

Install complete, press Enter to continue.

Also renaming "Install" to "Install/Update" could make sense as it is also the way to update the project

3: A launch with all options activated (except real hardware), when Ctrl+C in terminal is not stopping anything, it should stop everything and put us back to the TUI menu. But everything got stopped when exiting from the TUI

4: Using the console option, exiting with Ctrl+C or exit is not possible, Tmux Ctrl+B -> D is exiting the full lucy TUI

5: Launching the stack with Gazebo, then relaunching with Rviz (and unticking gazebo) is not stopping Gazebo run, but "hot-updating launch" activating/deactivating Rviz is working really good for example

Comment thread README.md
Comment thread windows/Lucy.py
@Mael-RABOT

Mael-RABOT commented May 29, 2026

Copy link
Copy Markdown
Contributor Author

@charlesmadjeri requested changes

1:Ticking Developer mode or not does not change the launch, we have the same launch menu Developer mode should be unticked by default when env is not set or not DEV=true, and be ticked by default when env is set to DEV=true, developer mode should also be the last element of the list, and separated by a blank line for install/build/launch.

This way the "default" user flow will be straightforward

2: After a run from TUI of target "Install", we got as output:

Install complete. Run ./launch_lucy.sh to start the stack.
--- Command finished with exit code 0 ---
Press Enter to exit.

Instead of prompting for re-run and exit, can we just prompt:

Install complete, press Enter to continue.

Also renaming "Install" to "Install/Update" could make sense as it is also the way to update the project

3: A launch with all options activated (except real hardware), when Ctrl+C in terminal is not stopping anything, it should stop everything and put us back to the TUI menu. But everything got stopped when exiting from the TUI

4: Using the console option, exiting with Ctrl+C or exit is not possible, Tmux Ctrl+B -> D is exiting the full lucy TUI

5: Launching the stack with Gazebo, then relaunching with Rviz (and unticking gazebo) is not stopping Gazebo run, but "hot-updating launch" activating/deactivating Rviz is working really good for example

  1. Quick UI, will do
  2. Quick UX, will do
    3 / 4. intended behaviour, user need to use the launcher.py to both run & stop everything.
  3. gazebo probably need a better shutdown than the generic command, will do

edit: Gazebo can't be closed by commands with the current architecture, will be left as such

Signed-off-by: Mael-RABOT <mael.rabot@gmail.com>
@m-brl m-brl self-requested a review May 30, 2026 12:39
m-brl
m-brl previously approved these changes May 30, 2026

@m-brl m-brl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No dev branch ?

@Arcod7

Arcod7 commented May 30, 2026

Copy link
Copy Markdown
Contributor
  • crash quand on resize down le terminal dans python3 Lucy.py
  • detection reactive de la taille du terminale (quand on nous dit que c’est trop petit, agrandir la taille devrait fix le probleme)
  • Launch en premier
  • Core et Control panel lance par defaut
  • Quand on fait ENTER apres Launch, ca doit passer sur le TMUX qui a lance le core
  • Trouver une maniere de relancer QUE le front

Arcod7
Arcod7 previously requested changes May 30, 2026
Signed-off-by: Mael-RABOT <mael.rabot@gmail.com>
Signed-off-by: Mael-RABOT <mael.rabot@gmail.com>
Signed-off-by: Mael-RABOT <mael.rabot@gmail.com>

@Arcod7 Arcod7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mael-RABOT Mael-RABOT merged commit f31cd9e into master May 31, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants