Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

bug when fast dragging tableview #27

Closed
ltfpeter opened this Issue Sep 7, 2012 · 5 comments

Comments

Projects
None yet
3 participants

ltfpeter commented Sep 7, 2012

Hi. There is a bug when I fast pull tableview down to refresh that will cause tableview cannot back to correct position.
The refresh control works nice when I drag the tableview slowly. But when I fast drag, even like a swipe gesture on the tableview, the refresh control will send event to its target to begin refresh,while the tableview is still scrolling inertially. And before the scrolling stop, the refresh request has finished and ask refresh control to end refreshing. Because of the continuing scrolling, the refresh control still receive the scrolling event and finally "hang the tableview in the air" with a content offset...

I'm not sure whether my description can be understood, you can try this situation under a very fast WIFI. It will occur..

Thx.

Contributor

minorblend commented Sep 10, 2012

I'm having the same problem after merging 27a5ba9 into my fork. although I'm looking into it, i'm not sure i can fix it fast enough.

Owner

Sephiroth87 commented Sep 10, 2012

I think the offending lines are these:

  •        CGPoint offset = blockScrollView.contentOffset;
    
  •        [blockScrollView setContentOffset:offset animated:NO];
    

in endRefresh:

Removing them seems to solve the bug, and I honestly can't remember why they're there in the first place, they seem to be doing nothing actually useful...
I'll investigate this a little more...

@Sephiroth87 Sephiroth87 reopened this Sep 10, 2012

Owner

Sephiroth87 commented Sep 10, 2012

So, I think it's fixed now, but a double check would be great, if you can :)

Contributor

minorblend commented Sep 10, 2012

it works well for me

This bug has been fixed. Thx

@ltfpeter ltfpeter closed this Sep 10, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment