From beb8c48f26c882a77d7ddf323463b6f0f07e08f0 Mon Sep 17 00:00:00 2001
From: Brian Gianforcaro <bgianf@serenityos.org>
Date: Mon, 30 Aug 2021 23:24:00 -0700
Subject: [PATCH] Meta: Don't allow overlap in sonar cube file classification

Test files were getting analyzed twice, which the tool does
not like, and causes it to exit with a fatal error.

Also make the workflow run in PRs anytime the file is edited,
so that we can get immediate feedback without waiting till the
next day.
---
 .github/workflows/sonar-cloud-static-analysis.yml | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/sonar-cloud-static-analysis.yml b/.github/workflows/sonar-cloud-static-analysis.yml
index a61dd46a1ae043..fc04b067512305 100644
--- a/.github/workflows/sonar-cloud-static-analysis.yml
+++ b/.github/workflows/sonar-cloud-static-analysis.yml
@@ -1,9 +1,13 @@
 name: Sonar Cloud Static Analysis
 on:
+  # Automatically run at the end of every day.
   schedule:
-    # At the end of every day
     - cron: '0 0 * * *'
 
+  # Run if this file is changed in a pull request (to get immediate feedback).
+  pull_request:
+    paths: [".github/workflows/sonar-cloud-static-analysis.yml"]
+
 jobs:
   build:
     name: Static Analysis
@@ -52,8 +56,8 @@ jobs:
           echo "sonar.cfamily.compile-commands=${{ github.workspace }}/Build/compile_commands.json" >> ${{ github.workspace }}/sonar-project.properties
           echo "sonar.cfamily.threads=2" >> ${{ github.workspace }}/sonar-project.properties
           echo "sonar.host.url=${{ env.SONAR_SERVER_URL }}" >> ${{ github.workspace }}/sonar-project.properties
-          echo "sonar.sources=." >> ${{ github.workspace }}/sonar-project.properties
-          echo "sonar.tests=${{ github.workspace }}/Tests,${{ github.workspace }}/Base/res,${{ github.workspace }}/Base/www" >> ${{ github.workspace }}/sonar-project.properties
+          echo "sonar.sources=AK,Build,Userland,Kernel,Meta" >> ${{ github.workspace }}/sonar-project.properties
+          echo "sonar.tests=Tests" >> ${{ github.workspace }}/sonar-project.properties
 
       # === OS SETUP ===
       # TODO: Is there someway to share these steps with the cmake.yml?