Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PixelPaint: Close tab now prompts for a save #10104

Merged
merged 1 commit into from Oct 7, 2021

Conversation

alexmajor
Copy link
Contributor

Fixes #8064

@alexmajor
Copy link
Contributor Author

I have opened this as #8736 is stale but takes inspiration from it. I have never written C++ before so feedback is expected and welcomed.

Copy link
Member

@bgianfo bgianfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two tiny nit picks.

Userland/Applications/PixelPaint/MainWidget.cpp Outdated Show resolved Hide resolved
Userland/Applications/PixelPaint/MainWidget.cpp Outdated Show resolved Hide resolved
Copy link
Member

@bgianfo bgianfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Copy link
Member

@TobyAsE TobyAsE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Also, welcome to the serenity project!

@awesomekling awesomekling merged commit d4a0eca into SerenityOS:master Oct 7, 2021
@alexmajor alexmajor deleted the feat/pp-closure branch October 7, 2021 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PixelPaint: ask to save when closing but has not yet created a file
4 participants