LibC+Ports: Add initial GDB 11.1 port #11278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Two issues have been addressed on my branch:
With these changes, we can now get to the GDB prompt. Note that it can't be used for debugging yet, as GDB needs to know how to run SerenityOS programs. |
|
Nice! |
|
FYI, @BertalanD & @IdanHo, I pulled your commits into my branch. If you want to send the Kernel one separately, that works for me too. |
They are required for gdb to build.
... instead of returning the maximum number of Processor objects that we can allocate. Some ports (e.g. gdb) rely on this information to determine the number of worker threads to spawn. When gdb spawned 64 threads, the kernel could not cope with generating backtraces for it, which prevented us from debugging it properly. This commit also removes the confusingly named `Processor::processor_count` function so that this mistake can't happen again.
This builds and runs, but crashes when you attempt to try to debug something at the moment.
Stack regions can't be made volatile, which makes it impossible for malloc to manage memory that's used for `sigaltstack()`. Let's use mmap instead. Co-authored-by: Idan Horowitz <idan.horowitz@gmail.com>
This allows the gdb port to compile with our `regs.h`.
These are compilation errors coming form upstream gdb.
This patch adds a ptrace based gdb backend, which is then enlightended to known how to read the serenity i386 registers via ptrace. This is just a basic implementation to get the port bootstrapped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This port now compiles, and has a gdb target that can now launch programs.
The programs get launched suspended, but if you resume them manually the programs run to completion under gdb.
Anyway, this seemed like a good place to checkpoint and get the work merged.
Let me know what you think!