LibWeb: ignore repeat(auto-fit/auto-fill, auto) as it is not allowed

[pixelspark]

Fixes #23154

[BuggieBot]

Hello!

One or more of the commit messages in this PR do not match the SerenityOS code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why.
Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

[kalenikaliaksandr]

please, add a layout test for this change so we can be sure it won't regress in the future :)

layout tests live here https://github.com/SerenityOS/serenity/tree/master/Tests/LibWeb/Layout

command that could be used to run tests ./Meta/serenity.sh test lagom LibWeb

[pixelspark]

please, add a layout test for this change so we can be sure it won't regress in the future :)

layout tests live here https://github.com/SerenityOS/serenity/tree/master/Tests/LibWeb/Layout

command that could be used to run tests ./Meta/serenity.sh test lagom LibWeb

OK, something like this then?

[kalenikaliaksandr]

OK, something like this then?

I think we have an undeclared rule to use layout-tests when it is possible, as in this case. ref-tests are usually used for testing paint-related things that can't be caught in layout dumps.

[AtkinsSJ]

This looks good! Thank you. :^)

[AtkinsSJ]

Oh whoops, Aliaksandr is right. A layout test would be better.

[kalenikaliaksandr]

great, thank you!

[pixelspark]

Related, this took way longer than expected. Turns out the headless-browser dumps the reference output too early, i.e. after loading "about:blank". The below patch fixed that for me (it would print "Loaded about:blank" and then the expected URL):

index 9a2a449f..1d4b3659 100644
--- a/Userland/Utilities/headless-browser.cpp
+++ b/Userland/Utilities/headless-browser.cpp
@@ -282,8 +282,8 @@ static ErrorOr<TestResult> run_dump_test(HeadlessWebContentView& view, StringVie
 
     if (mode == TestMode::Layout) {
         view.on_load_finish = [&](auto const& loaded_url) {
-            VERIFY(url.equals(loaded_url, URL::ExcludeFragment::Yes));
-
+            dbgln("Loaded: {}, need {}", loaded_url, url);
+            if(loaded_url == url) {
             // NOTE: We take a screenshot here to force the lazy layout of SVG-as-image documents to happen.
             //       It also causes a lot more code to run, which is good for finding bugs. :^)
             (void)view.take_screenshot();
@@ -293,7 +293,10 @@ static ErrorOr<TestResult> run_dump_test(HeadlessWebContentView& view, StringVie
             builder.append("\n"sv);
             builder.append(view.dump_paint_tree().release_value_but_fixme_should_propagate_errors());
             result = builder.to_string().release_value_but_fixme_should_propagate_errors();
+
+            
             loop.quit(0);
+            }
         };
         view.on_text_test_finish = {};
     } else if (mode == TestMode::Text) {

My invocation:

./Tests/LibWeb/rebaseline-libweb-test "/Users/tommy/Repos/serenity/Tests/LibWeb/Layout/input/grid/repeat-auto-fit-fill-cannot-have-auto.html"

[pixelspark]

Just let me know if you want me to include that in the PR :-)

[nico]

It's good to do one thing per PR. That seems unrelated to this one? (I don't know if it's something desirable for a different PR.)

[pixelspark]

Sure thing, #23156

[AtkinsSJ]

@pixelspark You ended up being our 1000th contributor, congrats! 🥳
I don't think it actually means anything, but it's cool regardless.

[pixelspark]

Cool, impressive milestone for the project 🎉