LibCrypto: Make a better ASN.1 parser #5344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's annoying to calculate it when it's already a member function.
alimpfard
force-pushed
the
asn1-parser
branch
3 times, most recently
from
7808c50
to
fbcca42
Compare
And use it to parse RSA keys. As a bonus, this one shouldn't be reading out of bounds or messing with the stack (as much) anymore.
This was copying a bunch of bigints for no reason.
alimpfard
force-pushed
the
asn1-parser
branch
from
fbcca42
to
e02219c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A modern, good-looking parser (that actually works)!
Should very likely fix #5317 and most other ASN.1/DER parser related bugs.
Hopefully sometime soon, I'll replace the hacky X509 certificate parser in LibTLS with this parser too.
Update: does fix #5317.