Jump to conversation Give feedback
Unresolved conversations (3)
@bcoles bcoles Mar 12, 2021
Using both `fprintf` and `perror` seems redundant. Simply `perror("unveil")` is sufficient.
Outdated
Userland/Utilities/unzip.cpp
@bcoles bcoles Mar 12, 2021
The `target_path` is effectively the same as `cwd` which is defined and unveiled earlier. `target_path` is a more future-proof name and it would make sense to group these together and use the same variable. This way, if someone adds support for decompressing to a user-specified directory (ie, `unzip -d /output/path`) in the future, they only need to change one line as there's no hard coded assumption of operating in the working directory.
Outdated
Userland/Utilities/unzip.cpp
@bcoles bcoles Mar 12, 2021
Using both `fprintf` and `perror` seems redundant. Simply `perror("unveil")` is sufficient.
Outdated
Userland/Utilities/unzip.cpp
Resolved conversations (1)
@bcoles bcoles Mar 12, 2021
The `unveil` state should be locked once all permitted paths have been set. Currently it is set but not locked. ```cpp unveil(nullptr, nullptr); ```
Userland/Utilities/unzip.cpp
@bblenard