Ports: ffmpeg 4.4 (+ relevant LibC additions) #6717
Conversation
Ports/ffmpeg/package.sh
Outdated
| port=ffmpeg | ||
| version=4.4 | ||
| useconfigure=true | ||
| files="https://ffmpeg.org/releases/ffmpeg-4.4.tar.gz ffmpeg-4.4.tar.gz a08992a9f62cf9877582565544e8e799" |
There was a problem hiding this comment.
You can interpolate with ${version} here twice in the filenames
Ports/ffmpeg/package.sh
Outdated
| version=4.4 | ||
| useconfigure=true | ||
| files="https://ffmpeg.org/releases/ffmpeg-4.4.tar.gz ffmpeg-4.4.tar.gz a08992a9f62cf9877582565544e8e799" | ||
| auth_type="md5" |
linusg
left a comment
linusg
left a comment
There was a problem hiding this comment.
please split the first commit into two separate, atomic commits :)
Ports/ffmpeg/package.sh
Outdated
| port=ffmpeg | ||
| version=4.4 | ||
| useconfigure=true | ||
| files="https://ffmpeg.org/releases/ffmpeg-4.4.tar.gz ffmpeg-4.4.tar.gz a08992a9f62cf9877582565544e8e799" |
There was a problem hiding this comment.
| files="https://ffmpeg.org/releases/ffmpeg-4.4.tar.gz ffmpeg-4.4.tar.gz a08992a9f62cf9877582565544e8e799" | |
| files="https://ffmpeg.org/releases/ffmpeg-${version}.tar.gz ffmpeg-${version}.tar.gz a08992a9f62cf9877582565544e8e799" |
Ports/ffmpeg/package.sh
Outdated
| version=4.4 | ||
| useconfigure=true | ||
| files="https://ffmpeg.org/releases/ffmpeg-4.4.tar.gz ffmpeg-4.4.tar.gz a08992a9f62cf9877582565544e8e799" | ||
| auth_type="md5" |
There was a problem hiding this comment.
auth_type=md5 is not supported anymore, please use sha256
Ports/ffmpeg/package.sh
Outdated
| --arch="x86_32" \ | ||
| --cc="i686-pc-serenity-gcc -std=gnu99" \ | ||
| --cxx="i686-pc-serenity-g++ -std=gnu99" \ | ||
| --disable-network \ | ||
| --enable-cross-compile |
There was a problem hiding this comment.
- Please don't mix tabs and spaces (spaces only)
- Please don't hardcode
i686(use${CC}and${CXX}instead ofi686-pc-serenity-gccandi686-pc-serenity-g++
|
Also, the commit message should say "Ports", not "Port". |
…ngs being passed to sscanf.
holdengreen
changed the title
|
Thanks guys! I think I've covered it... |
Ports/ffmpeg/package.sh
Outdated
| useconfigure=true | ||
| files="https://ffmpeg.org/releases/ffmpeg-${version}.tar.gz ffmpeg-${version}.tar.gz a4abede145de22eaf233baa1726e38e137f5698d9edd61b5763cd02b883f3c7c" | ||
| auth_type="sha256" | ||
| makeopts="-j$(nproc)" |
There was a problem hiding this comment.
This seems gratuitous, I don't think a random port should force parallelism on the build system.
There was a problem hiding this comment.
Good call. I got that line from the lua package script. (which is what I originally copied and modified because I'm familiar with lua)
During testing I compiled ffmpeg without parallelism (to make debugging easier) and I will warn that it did take a non-negligible amount of time to compile...
There was a problem hiding this comment.
Ok. I took care of it!
4 participants
Hi I've finally got something!
I've got ffmpeg 4.4 to run in SerenityOS.
It is now using a sha256 hash that I derived because I was having issues with gpg.
I have not extensively tested it in serenity yet, but it does seem to be missing media/library codecs that would make it more practically useful.
I'm still able to continue improving this port.