diff --git a/src/it/java/com/google/checkstyle/test/chapter3filestructure/rule332nolinewrap/NoLineWrapTest.java b/src/it/java/com/google/checkstyle/test/chapter3filestructure/rule332nolinewrap/NoLineWrapTest.java index 46094acd9fd6..c09dbf5962f7 100644 --- a/src/it/java/com/google/checkstyle/test/chapter3filestructure/rule332nolinewrap/NoLineWrapTest.java +++ b/src/it/java/com/google/checkstyle/test/chapter3filestructure/rule332nolinewrap/NoLineWrapTest.java @@ -44,6 +44,7 @@ public void badLineWrapTest() throws Exception { final String[] expected = { "1: " + getCheckMessage(NoLineWrapCheck.class, "no.line.wrap", "package"), "6: " + getCheckMessage(NoLineWrapCheck.class, "no.line.wrap", "import"), + "10: " + getCheckMessage(NoLineWrapCheck.class, "no.line.wrap", "import"), }; final Configuration checkConfig = getCheckConfig("NoLineWrap"); diff --git a/src/it/resources/com/google/checkstyle/test/chapter3filestructure/rule332nolinewrap/InputNoLineWrapBad.java b/src/it/resources/com/google/checkstyle/test/chapter3filestructure/rule332nolinewrap/InputNoLineWrapBad.java index 3a08153efdd2..8663ba4689b5 100644 --- a/src/it/resources/com/google/checkstyle/test/chapter3filestructure/rule332nolinewrap/InputNoLineWrapBad.java +++ b/src/it/resources/com/google/checkstyle/test/chapter3filestructure/rule332nolinewrap/InputNoLineWrapBad.java @@ -7,9 +7,12 @@ AccessibleAttributeSequence; import java.util.concurrent.atomic.AtomicIntegerFieldUpdater; //ok +import static java.math. //warn + BigInteger.ONE; + public class InputNoLineWrapBad { - + public void fooMethod() { final int @@ -24,4 +27,3 @@ interface InterFoo {} - diff --git a/src/it/resources/com/google/checkstyle/test/chapter3filestructure/rule332nolinewrap/InputNoLineWrapGood.java b/src/it/resources/com/google/checkstyle/test/chapter3filestructure/rule332nolinewrap/InputNoLineWrapGood.java index 12b3e56e438b..839626e582c4 100644 --- a/src/it/resources/com/google/checkstyle/test/chapter3filestructure/rule332nolinewrap/InputNoLineWrapGood.java +++ b/src/it/resources/com/google/checkstyle/test/chapter3filestructure/rule332nolinewrap/InputNoLineWrapGood.java @@ -1,12 +1,14 @@ package com.google.checkstyle.test.chapter3filestructure.rule332nolinewrap; //ok +import static java.math.BigInteger.ZERO; //ok + import com.puppycrawl.tools.checkstyle.checks.design.FinalClassCheck; //ok - + import java.util.concurrent.atomic.AtomicIntegerFieldUpdater; //ok import javax.accessibility.AccessibleAttributeSequence; //ok public class InputNoLineWrapGood { - + public void fooMethod() { // } diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/whitespace/NoLineWrapCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/whitespace/NoLineWrapCheck.java index 1f99db391d03..93be608f60da 100644 --- a/src/main/java/com/puppycrawl/tools/checkstyle/checks/whitespace/NoLineWrapCheck.java +++ b/src/main/java/com/puppycrawl/tools/checkstyle/checks/whitespace/NoLineWrapCheck.java @@ -72,13 +72,14 @@ public class NoLineWrapCheck extends AbstractCheck { @Override public int[] getDefaultTokens() { - return new int[] {TokenTypes.PACKAGE_DEF, TokenTypes.IMPORT}; + return new int[] {TokenTypes.PACKAGE_DEF, TokenTypes.IMPORT, TokenTypes.STATIC_IMPORT}; } @Override public int[] getAcceptableTokens() { return new int[] { TokenTypes.IMPORT, + TokenTypes.STATIC_IMPORT, TokenTypes.PACKAGE_DEF, TokenTypes.CLASS_DEF, TokenTypes.METHOD_DEF, diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/NoLineWrapCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/NoLineWrapCheckTest.java index 68cb0ebe296f..168bc2f1b44d 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/NoLineWrapCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/NoLineWrapCheckTest.java @@ -51,6 +51,7 @@ public void testDefaultTokensLineWrapping() throws Exception { final String[] expected = { "1: " + getCheckMessage(MSG_KEY, "package"), "6: " + getCheckMessage(MSG_KEY, "import"), + "10: " + getCheckMessage(MSG_KEY, "import"), }; verify(checkConfig, getPath("InputNoLineWrapBad.java"), expected); } @@ -59,12 +60,14 @@ public void testDefaultTokensLineWrapping() throws Exception { public void testCustomTokensLineWrapping() throws Exception { final DefaultConfiguration checkConfig = createCheckConfig(NoLineWrapCheck.class); - checkConfig.addAttribute("tokens", "IMPORT, CLASS_DEF, METHOD_DEF, ENUM_DEF"); + checkConfig.addAttribute( + "tokens", "IMPORT, STATIC_IMPORT, CLASS_DEF, METHOD_DEF, ENUM_DEF"); final String[] expected = { "6: " + getCheckMessage(MSG_KEY, "import"), - "10: " + getCheckMessage(MSG_KEY, "CLASS_DEF"), - "13: " + getCheckMessage(MSG_KEY, "METHOD_DEF"), - "20: " + getCheckMessage(MSG_KEY, "ENUM_DEF"), + "10: " + getCheckMessage(MSG_KEY, "import"), + "13: " + getCheckMessage(MSG_KEY, "CLASS_DEF"), + "16: " + getCheckMessage(MSG_KEY, "METHOD_DEF"), + "23: " + getCheckMessage(MSG_KEY, "ENUM_DEF"), }; verify(checkConfig, getPath("InputNoLineWrapBad.java"), expected); } diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/checks/whitespace/InputNoLineWrapBad.java b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/whitespace/InputNoLineWrapBad.java index 88465abff0e5..5a768ef7ba16 100644 --- a/src/test/resources/com/puppycrawl/tools/checkstyle/checks/whitespace/InputNoLineWrapBad.java +++ b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/whitespace/InputNoLineWrapBad.java @@ -1,15 +1,18 @@ -package com.puppycrawl.tools. +package com.puppycrawl.tools. //violation checkstyle.checks.whitespace; import com.puppycrawl.tools.checkstyle.TreeWalker; -import javax.accessibility. +import javax.accessibility. //violation AccessibleAttributeSequence; import java.util.concurrent.atomic.AtomicIntegerFieldUpdater; -public class +import static java.math. //violation + BigInteger.ZERO; + +public class //violation InputNoLineWrapBad { - + public void fooMethod() { final int @@ -17,7 +20,7 @@ } } -enum +enum //violation FooFoo { } diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/checks/whitespace/InputNoLineWrapGood.java b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/whitespace/InputNoLineWrapGood.java index 77853df53075..07e75e4d6de3 100644 --- a/src/test/resources/com/puppycrawl/tools/checkstyle/checks/whitespace/InputNoLineWrapGood.java +++ b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/whitespace/InputNoLineWrapGood.java @@ -5,8 +5,10 @@ import javax.accessibility.AccessibleAttributeSequence; import java.util.concurrent.atomic.AtomicIntegerFieldUpdater; +import static java.math.BigInteger.ZERO; + public class InputNoLineWrapGood { - + public void fooMethod() { // } diff --git a/src/xdocs/config_whitespace.xml b/src/xdocs/config_whitespace.xml index b7eb9bbe01f1..77c32dcfb6bb 100644 --- a/src/xdocs/config_whitespace.xml +++ b/src/xdocs/config_whitespace.xml @@ -856,6 +856,8 @@ class Foo IMPORT, STATIC_IMPORT, + PACKAGE_DEF, CLASS_DEF, @@ -871,7 +873,9 @@ class Foo PACKAGE_DEF, IMPORT. + href="apidocs/com/puppycrawl/tools/checkstyle/api/TokenTypes.html#IMPORT">IMPORT, + STATIC_IMPORT. @@ -881,11 +885,14 @@ class Foo Examples of line-wrapped statements (bad case):

-package com.puppycrawl. +package com.puppycrawl. //violation tools.checkstyle.checks; -import com.puppycrawl.tools. +import com.puppycrawl.tools. //violation checkstyle.api.AbstractCheck; + +import static java.math. //violation + BigInteger.ZERO;

To configure the check to force no line-wrapping @@ -908,6 +915,7 @@ import com.puppycrawl.tools.

import com.puppycrawl.tools.checkstyle.api.AbstractCheck; +import static java.math.BigInteger.ZERO;