[WIP] WIP Address feedback on Google ADK support #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Co-authored-by: OhYee <13498329+OhYee@users.noreply.github.com>
OhYee
approved these changes
Dec 5, 2025
Copilot stopped work on behalf of
OhYee due to an error
December 5, 2025 02:45
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a bug where accessing stream_options from kwargs could raise a KeyError when the key is not present. The fix uses kwargs.get("stream_options") instead of direct dictionary access kwargs["stream_options"] to safely handle cases where stream_options is not passed as an argument.
- Changed dictionary access pattern from
kwargs["stream_options"]tokwargs.get("stream_options")to prevent KeyError - Applied the fix consistently to both
completionsandresponsesmethods in theModelCompletionAPIclass
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KeyErrorwhenstream_optionsis not present inkwargsby usingkwargs.get("stream_options")instead ofkwargs["stream_options"]in bothcompletionsandresponsesmethods💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.