-
Notifications
You must be signed in to change notification settings - Fork 0
Several structural & UX improvements for Models Selector component #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several structural & UX improvements for Models Selector component #3
Conversation
allozaur
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, @ServeurpersoCom lemme know if it's good :)
b00c7f0
into
ServeurpersoCom:models-search
|
Thanks Alek I merge & test |
It needs to be constrained by the top of the viewport so it doesn't overflow on mobile, and pass over the famous sidebar button, and it will be perfect! |
😂
Thanks 😄 |
|
The correct zindex of the sidebar button will need to be implemented separately because I've noticed the problem is recurring; it will need to be fixed at the source in a small refactoring |
Sure, can be addressed with a direct PR without creating an issue, i think |
SearchInput.sveltecomponent in$lib/components/misc/ChatSidebarSearch.svelteto use the new shared componentModelsSelector.svelteto use ShadCN PopoverSearchInput.sveltewith new props:onKeyDownfor keyboard event handlingonClosecallback with X icon (clears value or closes parent)