Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: metrics panic when request is invalid. #211

Merged
merged 1 commit into from Dec 19, 2017

Conversation

little-cui
Copy link
Member

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 71.721% when pulling 087263c on little-cui:master into 2486c78 on ServiceComb:master.

@codecov-io
Copy link

Codecov Report

Merging #211 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #211   +/-   ##
=======================================
  Coverage   67.99%   67.99%           
=======================================
  Files          17       17           
  Lines        3584     3584           
=======================================
  Hits         2437     2437           
  Misses        974      974           
  Partials      173      173
Impacted Files Coverage Δ
server/service/service_dependency.go 76.52% <0%> (-0.87%) ⬇️
server/service/tag.go 74.41% <0%> (+0.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2486c78...087263c. Read the comment docs.

@little-cui little-cui merged commit c671101 into apache:master Dec 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants