Skip to content

Conversation

@zakir8992
Copy link
Contributor

PR Description:

Automatically Populate Incident with Work Order Number, State , OnHold Reason using business rule when a Work Order is created from an Incident

Pull Request Checklist

Overview

  • Put an x inside of the square brackets to check each item.
  • I have read and understood the CONTRIBUTING.md guidelines
  • My pull request has a descriptive title that accurately reflects the changes and the description has been filled in above.
  • I've included only files relevant to the changes described in the PR title and description
  • I've created a new branch in my forked repository for this contribution

Code Quality

  • My code is relevant to ServiceNow developers
  • My code snippets expand meaningfully on official ServiceNow documentation (if applicable)
  • I've disclosed use of ES2021 features (if applicable)
  • I've tested my code snippets in a ServiceNow environment (where possible)

Repository Structure Compliance

  • I've placed my code snippet(s) in one of the required top-level categories:
    • Core ServiceNow APIs/
    • Server-Side Components/
    • Client-Side Components/
    • Modern Development/
    • Integration/
    • Specialized Areas/
  • I've used appropriate sub-categories within the top-level categories
  • Each code snippet has its own folder with a descriptive name

Documentation

  • I've included a README.md file for each code snippet
  • The README.md includes:
    • Description of the code snippet functionality
    • Usage instructions or examples
    • Any prerequisites or dependencies
    • (Optional) Screenshots or diagrams if helpful

Restrictions

  • My PR does not include XML exports of ServiceNow records
  • My PR does not contain sensitive information (passwords, API keys, tokens)
  • My PR does not include changes that fall outside the described scope

@mskoddow mskoddow self-assigned this Oct 24, 2025
@mskoddow
Copy link
Contributor

Hi @zakir8992
this pull request looks like an extract from a customer implementation and then polished with the help of an AI tool. Is this correct?
Although I can understand the use case it's pretty special and does not match the idea of a general code repository.
Furthermore, there is no explanation about the prerequisites (e.g. having FSM application installed) and also instructions for creating the custom field on the incident table is missing.

@zakir8992
Copy link
Contributor Author

@mskoddow
Thanks for feedback
Yes, its was inspired by real FSM use case. Do you want me add prerequisite and instruction steps to readme file?
or should i close it if it does not match with general code repository ?

Copy link
Contributor

@mskoddow mskoddow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solution requires some configuration steps which are not explained in that file, like

  • installing FSM application
  • creating a custom field on the incident table and placing it on the incident form
  • adding a custom value in the "On Hold reason" field

Please explain these steps in the readme file and I will approve the PR.

Changes made as requested
@zakir8992
Copy link
Contributor Author

@mskoddow
I have added the prerequisites steps.
Thank you

Copy link
Contributor

@mskoddow mskoddow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect and many thanks for your contribution!

@mskoddow mskoddow merged commit 1106276 into ServiceNowDevProgram:main Oct 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants