diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt b/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt
index 7690be0..3f46f0c 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt
@@ -1 +1 @@
-ZOjLMA-C4RrIKNJc7i4svPHUEqPMY7c9JS9VarReiQPQ2sx2BGoBbm-1XwYKmazygymq8qa85ay0E9F21phcknYTmQ5Wla0JME5c2xmPQWV-x25CfLnK2a87yPJgQOQ7HTn2FiJm5bvBHXiX9fD_8MAwZF3EVUh1Vr6sJA_sKt_OCvResvBeRt1s9-eCyQOvcInU1hsSEm50eJNjRMTAVeWcMHNGPn1hNkcBouo0ZPJuSmgj8o67r6xIQXAX6o8smC17Tzo9UMoRr8p6MkfZuLs0-kikYzM9yE1gJuZqRSENu1oIYVxJsAfCaYllYyaf3B0NtRztaSaM8GuHrIiCMNky3KnxXs1otdzQOHzLVE15RHaLnnJxe3lRg20BuSitwNVbf4KZ4z0-1z5ncY2Oca9A3QLg7NNnW8zZWsAyl0THgnpTBVMqBMFelclDXoC9VUlPKFdMFiZ4T135v90kKcSEdLEn-wuIkzjXTTRnSB5AKasER_0ZB8QAA9ezvAzWBRgotzabgDT49UWcdj6D6nTaB8XbMCS2Ccj9YBGXS1W_gGVB8dFQL-NcHpRkG3TWdHSSNiKKSlM_S5N7aiw42W6wa8F_tHOsd28_hvYo1tdy2laSfCQ6kCHNzvrdQ_gnF6YzfcqLmVXTnD-yZhDPfIaek78TOoCqm5E82qgEmsc
+0x5JTGsuVftI6THFgd6j9kal0k6pwsnj87lodT9JdStqAayDcXdIdBk8dUx8rlf8_56U6lhRuZjOjMzr-8Bxhx9agM0G74E146s0Xejsu0kRSCW-gRwWm81jRtlvIeSfUAOc7KKbN8Yze_spJZd3xQ7KeA_eJT7XC35nPp2l3BtTSxbOJWAA3z__5StnoxHXag6QPhjIe9qvb872kl2ZksWp7PA0PUZ6S_VgFCRnzJVUy8EcuvDJLGzIZMtLhCQfftaWobqh96jpDGemEQtqxuefYrpgt8egIACDL3dgWSzd-MGaqx3ptqP9uyyAN_OWDu6sNpAJbjgxkvEx0vMMDIX6b9421p-LpoJDITTlI3yEsmXvAu7bOPvhbprXqOYC0w7BQ230UYBANBqgY15k6pttWnH6PyQU-mifsXPLg6OglVplGf884Y1Ak93-BANTOPNI1HwuQQIB_SWPyvL-_NLzMd7bNb9i-UtrjH4x4nZ1-DPVO6-iXSVm0IHdzHPxuM70OjDBZJN_v2tKekmwEGTgoD9bDIVnoODydrwjAsqZ1LxSNCKqkWN2VII0IEsSVrLAwzBl0SKWcQ4xo8pT2sssdxXOCd_eiXLVlYkSudrcK6DcmxugaXUajKumJkNt3rapqLTNsxXZ9jUHoRaVnUO5iGWi3ofqtw-ALdKOgS4
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_0b7623d41b1afc10ce0f62c3b24bcb24.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_0b7623d41b1afc10ce0f62c3b24bcb24.xml
index aa60df9..6651bdf 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_0b7623d41b1afc10ce0f62c3b24bcb24.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_0b7623d41b1afc10ce0f62c3b24bcb24.xml
@@ -29,7 +29,7 @@ Care should be taken when setting system properties (sys_properties) using this
return;
}
- if (childnode.getNameIdentifier() === "setProperty" || node.getNameIdentifier() === "cacheFlush") {
+ if (childnode.getNameIdentifier() === "setProperty" || childnode.getNameIdentifier() === "cacheFlush") {
method_found = true;
return;
}
@@ -45,21 +45,21 @@ Care should be taken when setting system properties (sys_properties) using this
engine.finding.incrementWithNode(node);
}
}
-
});
+
})(engine);]]>
Cache flushed as part of scripts
scan_linter_check
daniel.draes
2021-08-27 07:18:40
0b7623d41b1afc10ce0f62c3b24bcb24
- 8
+ 11
Cache flushed as part of scripts
ca8467c41b9abc10ce0f62c3b24bcbaa
ca8467c41b9abc10ce0f62c3b24bcbaa
scan_linter_check_0b7623d41b1afc10ce0f62c3b24bcb24
- daniel.draes
- 2021-08-27 08:12:47
+ mark.roethof
+ 2021-10-03 16:55:38
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_0eeac3042f0730103307235df699b6d1.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_0eeac3042f0730103307235df699b6d1.xml
new file mode 100644
index 0000000..9609d61
--- /dev/null
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_0eeac3042f0730103307235df699b6d1.xml
@@ -0,0 +1,43 @@
+
+
+ true
+ performance
+ getXMLAnswer only retrieves the Answer which we are actually after. getXML retrieves the whole XML document. In most cases, we are not interested in the whole XML document, though only in the Answer.
+For the rare cases where you are interested in the whole XML document, simply mute the generated scan finding.
+ https://community.servicenow.com/community?id=community_article&sys_id=1c10a1fedbbd4890feb1a851ca961909
+ scan_finding
+ Consider using getXMLAnswer instead of getXML
+ 3
+ Replace the usage of getXML by getXMLAnswer.
+
+ 100
+ 0
+ 1
+
+ Consider using getXMLAnswer instead of getXML
+ scan_linter_check
+ mark.roethof
+ 2021-10-02 17:26:47
+ 0eeac3042f0730103307235df699b6d1
+ 0
+ Consider using getXMLAnswer instead of getXML
+ ca8467c41b9abc10ce0f62c3b24bcbaa
+
+ ca8467c41b9abc10ce0f62c3b24bcbaa
+ scan_linter_check_0eeac3042f0730103307235df699b6d1
+ mark.roethof
+ 2021-10-02 17:26:47
+
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_2e2a8fc02f0730103307235df699b659.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_2e2a8fc02f0730103307235df699b659.xml
new file mode 100644
index 0000000..494589f
--- /dev/null
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_2e2a8fc02f0730103307235df699b659.xml
@@ -0,0 +1,42 @@
+
+
+ true
+ manageability
+ In general, you should use the array literal notation when possible. It is easier to read, it gives the compiler a chance to optimize your code, and it's mostly faster too.
+ https://www.java67.com/2014/08/difference-between-string-literal-and-new-String-object-Java.html
+ scan_finding
+ Don't use new Array()
+ 4
+ Use [] instead of new Array().
+
+ 100
+ 0
+ 1
+
+ Don't use new Array()
+ scan_linter_check
+ mark.roethof
+ 2021-10-02 17:23:33
+ 2e2a8fc02f0730103307235df699b659
+ 0
+ Don't use new Array()
+ ca8467c41b9abc10ce0f62c3b24bcbaa
+
+ ca8467c41b9abc10ce0f62c3b24bcbaa
+ scan_linter_check_2e2a8fc02f0730103307235df699b659
+ mark.roethof
+ 2021-10-02 17:23:33
+
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_51e943c02f0730103307235df699b64b.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_51e943c02f0730103307235df699b64b.xml
new file mode 100644
index 0000000..b8ac2c2
--- /dev/null
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_51e943c02f0730103307235df699b64b.xml
@@ -0,0 +1,42 @@
+
+
+ true
+ manageability
+ In general, you should use the object literal notation when possible. It is easier to read, it gives the compiler a chance to optimize your code, and it's mostly faster too.
+ https://www.java67.com/2014/08/difference-between-string-literal-and-new-String-object-Java.html
+ scan_finding
+ Don't use new Object()
+ 4
+ Use {} instead of new Object().
+
+ 100
+ 0
+ 1
+
+ Don't use new Object()
+ scan_linter_check
+ mark.roethof
+ 2021-10-02 17:22:22
+ 51e943c02f0730103307235df699b64b
+ 0
+ Don't use new Object()
+ ca8467c41b9abc10ce0f62c3b24bcbaa
+
+ ca8467c41b9abc10ce0f62c3b24bcbaa
+ scan_linter_check_51e943c02f0730103307235df699b64b
+ mark.roethof
+ 2021-10-02 17:22:22
+
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_b46a4fc02f0730103307235df699b6e0.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_b46a4fc02f0730103307235df699b6e0.xml
new file mode 100644
index 0000000..30c3823
--- /dev/null
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_b46a4fc02f0730103307235df699b6e0.xml
@@ -0,0 +1,95 @@
+
+
+ true
+ manageability
+ The "gs.log()", "gs.debug()", "console.log()", etc. statements can be used to write information to the system log, while the "gs.print()", etc. statements also sends it as output to the screen. It is generally used when debugging. Using "gs.log()", "gs.debug()", "console.log()", etc. statements on a production instance will pollute the system log, while it is never used as you do not perform debugging on a production instance.
+
+ scan_finding
+ Scripts should not contain debugging statements in production
+ 3
+ The best practice is to remove (commented) debug statements from scripts or making them conditionally controlled by a property.
+
+ 100
+ 0
+ 1
+
+ Scripts should not contain debugging statements in production
+ scan_linter_check
+ mark.roethof
+ 2021-10-02 17:24:32
+ b46a4fc02f0730103307235df699b6e0
+ 0
+ Scripts should not contain debugging statements in production
+ ca8467c41b9abc10ce0f62c3b24bcbaa
+
+ ca8467c41b9abc10ce0f62c3b24bcbaa
+ scan_linter_check_b46a4fc02f0730103307235df699b6e0
+ mark.roethof
+ 2021-10-02 17:24:32
+
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_script_only_check_7f8a38342f0330103307235df699b6b3.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_script_only_check_7f8a38342f0330103307235df699b6b3.xml
new file mode 100644
index 0000000..7944301
--- /dev/null
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_script_only_check_7f8a38342f0330103307235df699b6b3.xml
@@ -0,0 +1,59 @@
+
+
+ true
+ manageability
+ In general, for a single record only a few Workflow context will be running. If a high number of Workflow context are active, this often indicates an issue on the starting conditions of your Workflow. More then 10 active Workflow context is considered being a high number.
+
+ scan_finding
+ High number of workflows running for a single record
+ 2
+ Resolve the high number of triggered Workflow context and investigate the starting conditions of your Workflow and correct where necessary.
+
+ 100
+ 0
+ 1
+
+ High number of workflows running for a single record
+ scan_script_only_check
+ mark.roethof
+ 2021-10-04 14:52:29
+ 7f8a38342f0330103307235df699b6b3
+ 0
+ High number of workflows running for a single record
+ ca8467c41b9abc10ce0f62c3b24bcbaa
+
+ ca8467c41b9abc10ce0f62c3b24bcbaa
+ scan_script_only_check_7f8a38342f0330103307235df699b6b3
+ mark.roethof
+ 2021-10-04 14:52:29
+
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_33687cb02f0330103307235df699b685.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_33687cb02f0330103307235df699b685.xml
new file mode 100644
index 0000000..b6a33a5
--- /dev/null
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_33687cb02f0330103307235df699b685.xml
@@ -0,0 +1,41 @@
+
+
+ true
+ false
+ manageability
+ state=ready^sys_created_onRELATIVELT@minute@ago@5^EQ
+
+
+
+ External Communication Channel (ECC) Queue is a connection point between an instance and the MID Server. Jobs that the MID Server needs to perform are saved in this queue until the MID Server is ready to handle them. The default polling interval is set to 40 seconds. When there are unprocessed queue records, this can indicate a large volume of queue records, a processing issue in general, or a MID Server issue.
+
+ scan_finding
+ Unprocessed queues
+ 1
+ Investigate the unprocessed queue records.
+
+ 100
+ 0
+ 1
+
+ Unprocessed queues
+ scan_table_check
+ mark.roethof
+ 2021-10-04 14:43:47
+ 33687cb02f0330103307235df699b685
+ 0
+ Unprocessed queues
+ ca8467c41b9abc10ce0f62c3b24bcbaa
+
+ ca8467c41b9abc10ce0f62c3b24bcbaa
+ scan_table_check_33687cb02f0330103307235df699b685
+ mark.roethof
+ 2021-10-04 14:43:47
+
+ false
+
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_ae4970f02f0330103307235df699b60b.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_ae4970f02f0330103307235df699b60b.xml
new file mode 100644
index 0000000..c2539e6
--- /dev/null
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_ae4970f02f0330103307235df699b60b.xml
@@ -0,0 +1,56 @@
+
+
+ true
+ true
+ manageability
+ state=0^next_actionRELATIVELT@minute@ago@5^trigger_typeNOT IN2,9^system_idNOT INALL NODES,ACTIVE NODES^EQ
+
+
+
+
+
+ Schedules with a state "Ready" run at the next scheduled interval (this does not include schedules with trigger type "Run at System Startup" and "On Demand"). When there are unprocessed schedules, this can indicate a large volume of schedules, a processing issue in general, or errors on the individual schedule itself.
+ https://docs.servicenow.com/csh?topicname=c_ScheduledJobs.html&version=latest
+ scan_finding
+ Unprocessed schedules
+ 1
+ Investigate the unprocessed schedules.
+
+ 100
+ 0
+ 1
+
+ Unprocessed schedules
+ scan_table_check
+ mark.roethof
+ 2021-10-04 14:47:00
+ ae4970f02f0330103307235df699b60b
+ 0
+ Unprocessed schedules
+ ca8467c41b9abc10ce0f62c3b24bcbaa
+
+ ca8467c41b9abc10ce0f62c3b24bcbaa
+ scan_table_check_ae4970f02f0330103307235df699b60b
+ mark.roethof
+ 2021-10-04 14:47:00
+
+ false
+
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_b909b0f02f0330103307235df699b62c.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_b909b0f02f0330103307235df699b62c.xml
new file mode 100644
index 0000000..5a4b210
--- /dev/null
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_b909b0f02f0330103307235df699b62c.xml
@@ -0,0 +1,53 @@
+
+
+ true
+ true
+ manageability
+ system_idINALL NODES,ACTIVE NODES^EQ
+
+
+ Schedule records with system ID "all Nodes" or "active nodes", are considered to be parent schedules. Parent schedules that themselves will never run but instead spawn child jobs (of the same name) for each application node required by their definition. Jobs with system ID "all nodes", are typically background maintenance jobs required for general node health and management. Jobs with system ID "active nodes", are typically jobs that need to run the same event processor or other jobs that need increased processing bandwidth across the platform.
+
+ scan_finding
+ Parent All Nodes/Active Nodes without childs
+ 3
+ Investigate why the parent schedule has no child schedule records.
+
+ 100
+ 0
+ 1
+
+ Parent All Nodes/Active Nodes without childs
+ scan_table_check
+ mark.roethof
+ 2021-10-04 14:45:47
+ b909b0f02f0330103307235df699b62c
+ 0
+ Parent All Nodes/Active Nodes without childs
+ ca8467c41b9abc10ce0f62c3b24bcbaa
+
+ ca8467c41b9abc10ce0f62c3b24bcbaa
+ scan_table_check_b909b0f02f0330103307235df699b62c
+ mark.roethof
+ 2021-10-04 14:45:47
+
+ false
+
+
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_cc993cf02f0330103307235df699b60d.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_cc993cf02f0330103307235df699b60d.xml
new file mode 100644
index 0000000..a691e63
--- /dev/null
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_cc993cf02f0330103307235df699b60d.xml
@@ -0,0 +1,63 @@
+
+
+ true
+ true
+ manageability
+ active=true^EQ
+
+
+ Connection test for the remote instance defined did not result in a positive response.
+ https://docs.servicenow.com/csh?topicname=t_DefineARemoteInstance.html&version=latest
+ scan_finding
+ Could not verify Remote instance connection
+ 2
+ If this occurs for an existing remote instance connection, verify that the user used:
+- Is active;
+- Is not locked out;
+- Has an admin role;
+- Has a correct password set.
+
+ 100
+ 0
+ 1
+
+ Could not verify Remote instance connection
+ scan_table_check
+ mark.roethof
+ 2021-10-04 14:50:11
+ cc993cf02f0330103307235df699b60d
+ 0
+ Could not verify Remote instance connection
+ ca8467c41b9abc10ce0f62c3b24bcbaa
+
+ ca8467c41b9abc10ce0f62c3b24bcbaa
+ scan_table_check_cc993cf02f0330103307235df699b60d
+ mark.roethof
+ 2021-10-04 14:50:11
+
+ false
+
+