From fdd93defd6f99a56a0a54dd695a6b8d7f9ae22a4 Mon Sep 17 00:00:00 2001 From: admin Date: Tue, 10 Oct 2023 04:11:43 -0700 Subject: [PATCH 1/5] Added scan check for Running Business rules for transform map --- ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt | 2 +- ...check_e19656212ff1311002eb2ca62799b639.xml | 41 +++++++++++++++++++ 2 files changed, 42 insertions(+), 1 deletion(-) create mode 100644 ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_e19656212ff1311002eb2ca62799b639.xml diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt b/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt index b704213..4e6c252 100644 --- a/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt +++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt @@ -1 +1 @@ -IY4GU8kOs-cZd20LM9KzufTF8KpvhhPs1hQ-YbLAnWLZctdh80RFXi2aSkVJsjJDsNKlSzRqAyomAXYlUwwFeCGj77Grl9D5LzqPwFOyKUcYlwmP_s1PaEm0f5hPHsHP5Iph2pKt4d5Au5u5v4K_esgBCGfJ6K-J4zPs0cesugCPHZwx6EbPf8HUH8TlwerxKMaFGPeidk9qTwC0IIKLmT2dKN2YCZqrgrnmSZZkVbxCNXoBOSeS6ndW47pGOcZAsgUDDla-dOQb8e10ZeymJI_4zG3sISo-pYOul91JqVBhR1Kz4r5o18DL-XziSHUbl8_QCplLzqBqun0VtPSwilHFuqIHM13uYI9CwEiDYaM816gb0oyRXe8lWzh4t626OW0z3cZ6TPiOrwdpQQLB2GmjDjs5OcFDcWvGaMr5pnEkltvRKEwYp-6tLEqIYGAsSGgHFn0sXtmqpyRtJX5CnzeKKE6I3cxlU0959fOhRJTKgkAfSmlqmZDV3yyXrJzuRZcUosVkCFIOwwMge8SOpIuBZdncO_kqnF6cW5VJx9539V9TpTP4MNiFPMJXOhxWPdcCLrieW2b6O5cFcO6FkiwPAoOIue8XOUVXq7Sc0ZUV_ehqdT4AG9zsrB82nFGrTbB4vvPkeCBaMoteUD6cucNuE2xw8UiJkVbtIo-RZG8 \ No newline at end of file +APBZ6N-mXQqTnbxQsCc2BHSyXp9Boqw2IPsl8t_tiGfkZCie3Y_HBRDI1ohtO9n5IZjYoWFKvqlA7F7fyv96kTOlFKK6GyU-tdiUoEqcOGb6K1x9t2oX4vonME33VyIwpeelR7UEPVuU9fQofwdQKQ0g-16C3mEXbfGXvhmgI7kxGU4eJl06omxI8VrED2HXXpiEPV76_WMvd14z3Iddfk2uo2ygohHSAtREtUmG4IZJVbcu4Hc4nWbhOEPeA1jYNPFFcvTK3iwpX8FUgYNRTYQfrCg1BSy8AoozxzFjn8_WX0mi10IhJzRZwrJCXfWhhVQoGdiCvYCqcogxDtNaDUzxkw20MbNXo6-AZpcJMH1EovFOJOS0CzqJ-KdnOKhSooYh7emFWG8xFZrzZi149t4Dq3aWft40Z4g7AjpgXt_7EO_NvCXBaHnXMwSOaiA-PoW2JL_FKI3AIduUybr3xPwQYP4Zbz2UzQtVVMOMeMFTs7JAqoHNkOG-jQNRAa_Bbq4cY_Ru6leaPdKEKVa3IDl1mf9ug7dcVhfkFDszOWRdRWDmJGi-ptN5twYZ_5IFEqIl_9YmylsKX-JobM4bDl-80xGd2v7z96Yj2oZg0ArGuO7EG6BwdQkmT-fvSwrBFawNWPX-OSdoRXoCc217pNPfsXFVNqBZ-sLza74ikRM \ No newline at end of file diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_e19656212ff1311002eb2ca62799b639.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_e19656212ff1311002eb2ca62799b639.xml new file mode 100644 index 0000000..323d167 --- /dev/null +++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_e19656212ff1311002eb2ca62799b639.xml @@ -0,0 +1,41 @@ + + + true + false + performance + run_business_rules=true^active=true^EQ + + + + Running business rules during transform may cause the transform to take longer than expected, or cause the instance to slow down. + https://docs.servicenow.com/bundle/vancouver-integrate-applications/page/administer/technical-best-practice/concept/c_TroubleshootImportSetPerformance.html + scan_finding + Running Business Rules on Transform Maps + 1 + Do not run items like business rules, workflows, approval engines, and so on during a transform unless you want all insert and update business rules, notifications, and workflows to run. For example, when importing all data from an old system, you may not want notifications to run. To disable these items from running and to cease auditing and field normalization within the transform map for that import, deselect the Run business rules check box. + + 100 + 0 + 1 + + Running Business Rules on Transform Maps + scan_table_check + admin + 2023-10-10 11:06:48 + e19656212ff1311002eb2ca62799b639 + 1 + Running Business Rules on Transform Maps + ca8467c41b9abc10ce0f62c3b24bcbaa + + ca8467c41b9abc10ce0f62c3b24bcbaa + scan_table_check_e19656212ff1311002eb2ca62799b639 + admin + 2023-10-10 11:08:53 + sys_transform_map
+ false + + From 11dee72235aa3d175b4433788f7187bb94069cbb Mon Sep 17 00:00:00 2001 From: admin Date: Wed, 11 Oct 2023 06:53:35 -0700 Subject: [PATCH 2/5] Scan check for "Use GlideRecordSecure instead of GlideRecord API for CCSI" --- ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt | 2 +- ...check_076448b12ffd311002eb2ca62799b628.xml | 43 +++++++++++++++++++ 2 files changed, 44 insertions(+), 1 deletion(-) create mode 100644 ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_076448b12ffd311002eb2ca62799b628.xml diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt b/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt index 4e6c252..9c51344 100644 --- a/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt +++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt @@ -1 +1 @@ -APBZ6N-mXQqTnbxQsCc2BHSyXp9Boqw2IPsl8t_tiGfkZCie3Y_HBRDI1ohtO9n5IZjYoWFKvqlA7F7fyv96kTOlFKK6GyU-tdiUoEqcOGb6K1x9t2oX4vonME33VyIwpeelR7UEPVuU9fQofwdQKQ0g-16C3mEXbfGXvhmgI7kxGU4eJl06omxI8VrED2HXXpiEPV76_WMvd14z3Iddfk2uo2ygohHSAtREtUmG4IZJVbcu4Hc4nWbhOEPeA1jYNPFFcvTK3iwpX8FUgYNRTYQfrCg1BSy8AoozxzFjn8_WX0mi10IhJzRZwrJCXfWhhVQoGdiCvYCqcogxDtNaDUzxkw20MbNXo6-AZpcJMH1EovFOJOS0CzqJ-KdnOKhSooYh7emFWG8xFZrzZi149t4Dq3aWft40Z4g7AjpgXt_7EO_NvCXBaHnXMwSOaiA-PoW2JL_FKI3AIduUybr3xPwQYP4Zbz2UzQtVVMOMeMFTs7JAqoHNkOG-jQNRAa_Bbq4cY_Ru6leaPdKEKVa3IDl1mf9ug7dcVhfkFDszOWRdRWDmJGi-ptN5twYZ_5IFEqIl_9YmylsKX-JobM4bDl-80xGd2v7z96Yj2oZg0ArGuO7EG6BwdQkmT-fvSwrBFawNWPX-OSdoRXoCc217pNPfsXFVNqBZ-sLza74ikRM \ No newline at end of file +AJInFJMOarSNZgy4eVPEI6ZUZTQO4buAfQ2jkBnzn77pHO8fWCuHP6neLRGKEC7iHlLsbGUl7is0NbkoHxzYWRkTwTxhYVY8p9qCuZPB6YXTBkKDo8X2oq-DOGp4hb5uwk5ES8I7a5hNCsIupO6JhrWFLLh9qeaJE6_nOsE-dMhwybJBxSvcaKmrcNqz51GJVu2Xb924Gs7sa1p1UzRVoKKd1z51VqR_oDCNJThz-yAlVdbnTqEKTdU9D98hy8yFXdRNPBow85OFDE3XWTjcfikcrqdULj0MLLarAcUvTuUgMfGBdFJYbnVNpxi7tVUR1SQ2aehcEujbsK-xJEY9kxmygBiddEm1KK1qiSlPJxRpEYo2doHSfVsxddkjkJyz8Ulja82BKj3D4i2EsUR75GcJzwmfgafdoO-pPRRarwYzGDUbWpe1iCTbmJHSZ_OxJTiJTiWGET89NVxYQZ80w3xSAPg7eyjtv4O3ezYEb4fAAQTiRH-6DwihD62dtq9qXKirZdtq9sa8mBL6UQJ_u5EqIeNo7bvkflLQgojzcUf4pM5pc_VHEgfmpEah9Qv6T98rIPOdMkH_dAB5q3uvbmBcPdOy_pNXjNEyLa28W5X9WA6nG3Qu3C0sW-oupQc1u2VgLrFj1hXAkdFHKn-oBIzWc6_--zdSXs70dzyZFBg \ No newline at end of file diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_076448b12ffd311002eb2ca62799b628.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_076448b12ffd311002eb2ca62799b628.xml new file mode 100644 index 0000000..dc51983 --- /dev/null +++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_076448b12ffd311002eb2ca62799b628.xml @@ -0,0 +1,43 @@ + + + true + false + security + active=true^client_callable=true^scriptLIKEnew GlideRecord(^ORscriptLIKEnew GlideRecord (^EQ + + + + + + Using GlideRecord API in Client Callable Script Include for database query exposes data security risk + https://docs.servicenow.com/bundle/utah-api-reference/page/script/server-scripting/concept/c_ScriptIncludes.html#title_client-callable-script-includes + scan_finding + Use GlideRecordSecure instead of GlideRecord API for CCSI + 2 + Use GlideRecordSecure API to ensure the security checks are performed and unauthorized access of data is prevented as it will automatically enforce ACLs. + + 100 + 0 + 1 + + Use GlideRecordSecure instead of GlideRecord API for Client Callable Script Inc + scan_table_check + admin + 2023-10-10 19:52:19 + 076448b12ffd311002eb2ca62799b628 + 3 + Use GlideRecordSecure instead of GlideRecord API for CCSI + ca8467c41b9abc10ce0f62c3b24bcbaa + + ca8467c41b9abc10ce0f62c3b24bcbaa + scan_table_check_076448b12ffd311002eb2ca62799b628 + admin + 2023-10-11 13:38:32 + sys_script_include
+ false + + From 012b9a7d87536e59df0d7dec5d815d9b28c5a1c3 Mon Sep 17 00:00:00 2001 From: admin Date: Fri, 13 Oct 2023 06:42:14 -0700 Subject: [PATCH 3/5] Adding linter scan check for setValue display parameter --- ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt | 2 +- ...check_85c352ae2f3db11002eb2ca62799b68e.xml | 47 +++++++++++++++++++ 2 files changed, 48 insertions(+), 1 deletion(-) create mode 100644 ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_85c352ae2f3db11002eb2ca62799b68e.xml diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt b/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt index 9c51344..dc0907b 100644 --- a/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt +++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt @@ -1 +1 @@ -AJInFJMOarSNZgy4eVPEI6ZUZTQO4buAfQ2jkBnzn77pHO8fWCuHP6neLRGKEC7iHlLsbGUl7is0NbkoHxzYWRkTwTxhYVY8p9qCuZPB6YXTBkKDo8X2oq-DOGp4hb5uwk5ES8I7a5hNCsIupO6JhrWFLLh9qeaJE6_nOsE-dMhwybJBxSvcaKmrcNqz51GJVu2Xb924Gs7sa1p1UzRVoKKd1z51VqR_oDCNJThz-yAlVdbnTqEKTdU9D98hy8yFXdRNPBow85OFDE3XWTjcfikcrqdULj0MLLarAcUvTuUgMfGBdFJYbnVNpxi7tVUR1SQ2aehcEujbsK-xJEY9kxmygBiddEm1KK1qiSlPJxRpEYo2doHSfVsxddkjkJyz8Ulja82BKj3D4i2EsUR75GcJzwmfgafdoO-pPRRarwYzGDUbWpe1iCTbmJHSZ_OxJTiJTiWGET89NVxYQZ80w3xSAPg7eyjtv4O3ezYEb4fAAQTiRH-6DwihD62dtq9qXKirZdtq9sa8mBL6UQJ_u5EqIeNo7bvkflLQgojzcUf4pM5pc_VHEgfmpEah9Qv6T98rIPOdMkH_dAB5q3uvbmBcPdOy_pNXjNEyLa28W5X9WA6nG3Qu3C0sW-oupQc1u2VgLrFj1hXAkdFHKn-oBIzWc6_--zdSXs70dzyZFBg \ No newline at end of file +qGgV-DohAJuHhA27vlb1U1MLDSQYvSasI8QuZRm-NG0yEwDyt5mNvvMle07OAmPdwoCzpnKQunbGMSgt0xweXbcj1kPi3uGSB2GOjPxQZRCqeJ7KDj6BsTGodgvDV5S9yfqcGFjvPl9FzCfiNCUwYcY_gtUoUGTqfiD_K3IrEzPgZf2f2Nzj5QF-5FFjUKdzqoL8xk83bizQ9NV9bkkEZS3FsjXbva85_S2ofq92ImVqJtk1or80SCXJCru7KbcePp4adTHLEv4fwfKtivp5ONLViBg1VYgEWxkKAq4OVxdOmil4x6RMtBBCoV8RuF9wIIeMUTTJc5kkjvP389rpv6aczHTOKgeeCtXlyCieirR3tG3Bker9Z3Ara3ZTW88UunoFa0s52SSvGm-vcvSuCRAkPY0O8LSeM0KF9DhEUjdoPIZGJd-7iCW_gQBdjbM6hgZ89G9819saOliBxmjqMO6Fx3XRYmAxSf7q7pCwUpUuqpGb3ptMFXTKrpIrHuc4vE3IvkL2oExdZRgJh2tfJsqSYXyOrEkeYyBzyHqlX5ZtBM-k91xTegi57Y9ZA1QlmN-4JbgN7ByuEs3T6UCcT_lTG9JKIfFAPgbbd5rOUvoBpqpvzbU9pu8L5fICM2M8Ah37PVPR1p_KqPQx56d1ns9B3QDqvUUkn-rOx2uZ8L4 \ No newline at end of file diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_85c352ae2f3db11002eb2ca62799b68e.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_85c352ae2f3db11002eb2ca62799b68e.xml new file mode 100644 index 0000000..4140127 --- /dev/null +++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_85c352ae2f3db11002eb2ca62799b68e.xml @@ -0,0 +1,47 @@ + + + true + performance + When using setValue() on a reference field, be sure to include the display value with the value (sys_id). If you set the value without the display value, ServiceNow does a synchronous Ajax call to retrieve the display value for the record you specified. This extra round trip to the server can leave you at risk of performance issues. + https://developer.servicenow.com/dev.do#!/guides/tokyo/now-platform/tpb-guide/client_scripting_technical_best_practices + scan_finding + Using setValue()'s displayValue Parameter with Reference Fields + 3 + Using the third parameter, where display name of the reference record can be passed. + + 100 + 0 + 1 + + Using setValue()'s displayValue Parameter with Reference Fields + scan_linter_check + admin + 2023-10-13 13:18:39 + 85c352ae2f3db11002eb2ca62799b68e + 1 + Using setValue()'s displayValue Parameter with Reference Fields + ca8467c41b9abc10ce0f62c3b24bcbaa + + ca8467c41b9abc10ce0f62c3b24bcbaa + scan_linter_check_85c352ae2f3db11002eb2ca62799b68e + admin + 2023-10-13 13:41:14 + + From c032e3ea8f5f81b6facb6c7d1c73ad6ce7a1f1d2 Mon Sep 17 00:00:00 2001 From: Aman Kumar <50793474+aman2519@users.noreply.github.com> Date: Fri, 13 Oct 2023 19:13:43 +0530 Subject: [PATCH 4/5] Update README.md --- README.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/README.md b/README.md index cb5ac3b..a482518 100644 --- a/README.md +++ b/README.md @@ -179,6 +179,9 @@ api.controller = function ($rootScope, $scope) { ### Provide alternate value when fetching Glide property Recommendation to provide alternate/default value when calling gs.getProperty() to avoid errors if the property is not set. +### Using setValue()'s displayValue Parameter with Reference Fields +When using setValue() on a reference field, be sure to include the display value with the value (sys_id). If you set the value without the display value, ServiceNow does a synchronous Ajax call to retrieve the display value for the record you specified. This extra round trip to the server can leave you at risk of performance issues. + ## Category: Security ##Check Mandatory fields on incident This check is used to find mandatory fields on incident From 82b3d5815343f92462a46f4e90933d7776a3ba8a Mon Sep 17 00:00:00 2001 From: admin Date: Fri, 13 Oct 2023 07:57:22 -0700 Subject: [PATCH 5/5] Updated scan check --- ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt | 2 +- .../scan_linter_check_85c352ae2f3db11002eb2ca62799b68e.xml | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt b/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt index dc0907b..8baedcf 100644 --- a/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt +++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt @@ -1 +1 @@ -qGgV-DohAJuHhA27vlb1U1MLDSQYvSasI8QuZRm-NG0yEwDyt5mNvvMle07OAmPdwoCzpnKQunbGMSgt0xweXbcj1kPi3uGSB2GOjPxQZRCqeJ7KDj6BsTGodgvDV5S9yfqcGFjvPl9FzCfiNCUwYcY_gtUoUGTqfiD_K3IrEzPgZf2f2Nzj5QF-5FFjUKdzqoL8xk83bizQ9NV9bkkEZS3FsjXbva85_S2ofq92ImVqJtk1or80SCXJCru7KbcePp4adTHLEv4fwfKtivp5ONLViBg1VYgEWxkKAq4OVxdOmil4x6RMtBBCoV8RuF9wIIeMUTTJc5kkjvP389rpv6aczHTOKgeeCtXlyCieirR3tG3Bker9Z3Ara3ZTW88UunoFa0s52SSvGm-vcvSuCRAkPY0O8LSeM0KF9DhEUjdoPIZGJd-7iCW_gQBdjbM6hgZ89G9819saOliBxmjqMO6Fx3XRYmAxSf7q7pCwUpUuqpGb3ptMFXTKrpIrHuc4vE3IvkL2oExdZRgJh2tfJsqSYXyOrEkeYyBzyHqlX5ZtBM-k91xTegi57Y9ZA1QlmN-4JbgN7ByuEs3T6UCcT_lTG9JKIfFAPgbbd5rOUvoBpqpvzbU9pu8L5fICM2M8Ah37PVPR1p_KqPQx56d1ns9B3QDqvUUkn-rOx2uZ8L4 \ No newline at end of file +EwzwYi9oGVvBPFVVP4VvTH8iqkJk6zG-ugt1IQoWzimJwfCK41JFgpYBAyaYT9WYBgBmwJnQIukNiq2zOdAxDHmJun9N0Mpe6Q9Lp0vaj_pCeUgq2-o_QQLrSsmGtE-v7jCix_Je-lRKCEXfm_qaFmVsuZ_cCorZXg_Jh3Y8MQyxzRe_FSPPYBoORzY15gkeKONfUpUHG1secSFdVx5guLGl8khrY9sxTVpJlby1TzM5jA9HbeTqjVst4cv8OrbSppCCjRT7fdORqksNN_f4AbOW5UlGFQC4NnWuhGbOb6Wh5Jbuf2mAc3889aXO__tXaxarYujlHR-JAYnvFEtJB_W3kyfy1E6l-wvjPFPi0HD3jEA0YaHXUlypJ-U0EPfIs_W6zWnypB5ODwQ3ntGOr8eBbbNuqySIrJNCsciq5n8gT31eL71q_MDX6boGnIoOxDpwuSX7qr1AeQdW1H4X-7m1oVbnyPhzDLgbCL2kkXcoVhhZ4YjQ8JkcXNf81FekS1P-jmpZZmFPmixFUrNHbGWt3M28LRdxmk1MM_av-Dc94sH7Ic6tmcZwNScfjbVhzCHH3wI6DH8ewsC2ZTYQ17BaT4pNwPNTiMBGHHszEYIWy41DIoe-tLfgPyf8woq5LrQrkqLck3EVrvP6EXX12x0iop0F9V1J2KIY0SuEKFk \ No newline at end of file diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_85c352ae2f3db11002eb2ca62799b68e.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_85c352ae2f3db11002eb2ca62799b68e.xml index 4140127..146e847 100644 --- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_85c352ae2f3db11002eb2ca62799b68e.xml +++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_linter_check_85c352ae2f3db11002eb2ca62799b68e.xml @@ -20,7 +20,7 @@ // looks for all occurrences of g_form.setvalue() and verifies it has all the relevant // paramters, which includes display name to avoid the synchronous ajax call - var pattern = /g_form\.setValue\(([^,]*),([^,]*),([^)]*)\)/gm; + var pattern = /g_form\.setValue\(([^,]*),([^,]*)\)/gm; var regExp = new RegExp(pattern); var matchFound = regExp.test(text); if (matchFound){ @@ -35,13 +35,13 @@ admin 2023-10-13 13:18:39 85c352ae2f3db11002eb2ca62799b68e - 1 + 2 Using setValue()'s displayValue Parameter with Reference Fields ca8467c41b9abc10ce0f62c3b24bcbaa ca8467c41b9abc10ce0f62c3b24bcbaa scan_linter_check_85c352ae2f3db11002eb2ca62799b68e admin - 2023-10-13 13:41:14 + 2023-10-13 14:49:20