Non-interface / non-abstract-typed property of a derived class should not have type info #250

Merged
merged 1 commit into from Dec 9, 2012

2 participants

@ShamsulAmry

Current case

When a class is serialized as one of its base class / interface, the type info of that class will be serialized. However, in addition to that, all of its properties will have their type info serialized as well which will cause unneeded extra characters being generated.

Result of this commit

The properties will only have their type info serialized on per required basis.

Tests

ServiceStack.Text.Tests.JsvTests.GeneratedJsvTests created for this commit. All existing tests passed.

@ShamsulAmry ShamsulAmry Non-interface / non-abstract-typed property of a derived class should…
… not have type info

Current case: When a class is serialized as one of its base class / interface, the type info of that class will be serialized. However, in addition to that, all of its properties will have their type info serialized as well which will cause unneeded extra characters being generated.

Result of this commit: The properties will only have their type info serialized on per required basis.

Tests: ServiceStack.Text.Tests.JsvTests.GeneratedJsvTests created for this commit. All existing tests passed.
067ce1f
@mythz mythz merged commit c4b69e8 into ServiceStack:master Dec 9, 2012
@mythz
ServiceStack member

Cool, thx! Just in time for tonights deployment :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment