Skip to content

populate response body #261

Merged
merged 1 commit into from Sep 20, 2012

3 participants

@allenarthurgay

in clientbase handleexception to allow for more flexible error handling. This is a change we have been using at Daptiv and would like to get it into the base repo so that we can more easily update our fork

@mythz mythz merged commit 953c810 into ServiceStack:master Sep 20, 2012
@mythz
ServiceStack member
mythz commented Sep 20, 2012

cool, thx!

@desunit
ServiceStack member
desunit commented Sep 20, 2012

It seems that commit broke 12 tests. @mythz, take a look at build 157. Exception is the same for most of thme:

Test(s) failed. System.NullReferenceException : Object reference not set to an instance of an object.
   at ServiceStack.WebHost.IntegrationTests.Tests.CustomerServiceValidationTests.Get_empty_request_throws_validation_exception(IRestClient client) in c:\BuildAgent\work\123e7c5a6bd2910f\tests\ServiceStack.WebHost.IntegrationTests\Tests\CustomerServiceValidationTests.cs:line 102
@mythz
ServiceStack member
mythz commented Sep 20, 2012

yep, will look at trying to fix the build errors tonight

@mythz
ServiceStack member
mythz commented Sep 20, 2012

hmmm seems like this contains a bug trying to re-read twice from the same stream. @allenarthurgay was this tested before this pull request was issued?

@allenarthurgay
@allenarthurgay
@mythz
ServiceStack member
mythz commented Sep 21, 2012

Never mind I decided to fixed this - I don't like broken builds.

Can you verify future pull-requests get tested before submitting.
thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.