Fix for issue #538 #540
Merged
Fix for issue #538 #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added check of WWW-Authenticate header for required security method Added code to generate a Digest response for the Authentication header Added utility code around the above.
…ests (E.g. nc value)
|
Now just figured out how to persist authentication requirements between requests. The NC value is incrememnted on each request now. Checked the code to ensure it works on all requests (via PrepareWebRequest method). |
|
Ok cool, if you could also provide an integration test somewhere, e.g. in ServiceStack.WebHost.Endpoints.Tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added check of WWW-Authenticate header for required security method
Added code to generate a Digest response for the Authentication header
Added utility code around the above.
Added computation of the Digest Authenticate header, and detection of whether it's Basic or Digest required by the server.
I don't currently save the nc between requests - I need a pointer on where/how I can do this for all service clients. (Can I just save this as a protected property internally to the ServiceClientBase class?)