Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: Inconsistent usage of DateTime.Now and .UtcNow in RabbitMqQueueClient #999

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@gabrielvdk
Copy link

gabrielvdk commented Aug 2, 2015

Fixed bug in RabbitMqQueueClient that caused the time out based Get to do an invalid calculation of the time span. It would always do a comparison between a DateTime.UtcNow based start time and a DateTIme.Now (not UTC) current time. This meant that on all machines not running on UTC time the initial difference would always be the difference between Utc-time and the time of time zone configured on the host machine.

Fixed bug in RabbitMqQueueClient that caused the time out based Get<T…
…> to do an invalid calculation of the time span. It would always do a comparison between a DateTime.UtcNow based start time and a DateTIme.Now (not UTC) current time. This meant that on all machines not running on UTC time the initial difference would always be the difference between Utc-time and the time of time zone configured on the host machine.

mythz added a commit that referenced this pull request Aug 2, 2015

@mythz

This comment has been minimized.

Copy link
Member

mythz commented Aug 2, 2015

Hi thx for the fix 👍

I've committed in manually in 69f6b87 as this PR included local path changes to /.vs/config/applicationhost.config, which have since been ignored: b6751ab

Please also approve the Contributor License Agreement so we're able to merge future PR's.

@mythz mythz closed this Aug 2, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.