This repository was archived by the owner on Jan 18, 2023. It is now read-only.
RebalancingSetToken code organization and touch ups #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2996
💛 - Coveralls |
asoong
approved these changes
Nov 25, 2018
| // Create combined token Array | ||
| address[] memory oldComponents = currentSetInstance.getComponents(); | ||
| address[] memory newComponents = nextSetInstance.getComponents(); | ||
|
|
Contributor
There was a problem hiding this comment.
nit: I prefer to not have the space when newComponents was invoked so that it can be called in the next line. Also makes the comment orphaned
| * unit of the two sets. | ||
| */ | ||
| function auctionSetUp() | ||
| function setUpAuctionDataStructures() |
Contributor
There was a problem hiding this comment.
setupAuctionParameters maybe? dataStructures is goofy
Contributor
There was a problem hiding this comment.
+1 since it does more than just set up the arrays it also defines the minimumBid too.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.