This repository was archived by the owner on Jan 18, 2023. It is now read-only.
Alex/implement whitelist for propose #340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asoong
force-pushed
the
alex/implement_whitelist_for_propose
branch
from
b306ee9 to
0aaba9a
Compare
felix2feng
reviewed
Jan 7, 2019
| // to a propose that prohibit the set from carrying out an auction i.e. a token that only the manager possesses | ||
| IWhiteList rebalanceComponentWhitelist = IRebalancingSetFactory(_factory).rebalanceComponentWhitelist(); | ||
| address[] memory components = ISetToken(_nextSet).getComponents(); | ||
| for (uint256 i = 0; i < components.length; i++) { |
Contributor
There was a problem hiding this comment.
We could reduce the calls to whitelist by passing the array of components to the whitelist contract
|
|
||
| // Check proposed components on whitelist. This is to ensure managers are unable to add contract addresses | ||
| // to a propose that prohibit the set from carrying out an auction i.e. a token that only the manager possesses | ||
| IWhiteList rebalanceComponentWhitelist = IRebalancingSetFactory(_factory).rebalanceComponentWhitelist(); |
Contributor
There was a problem hiding this comment.
If we do not believe that the factory will change (which it shouldn't), we could cache the rebalanceComponentWhitelist in a state variable
Pull Request Test Coverage Report for Build 3567
💛 - Coveralls |
asoong
force-pushed
the
alex/implement_whitelist_for_propose
branch
from
42e3798 to
a7882af
Compare
bweick
approved these changes
Jan 7, 2019
bweick
reviewed
Jan 7, 2019
| /** | ||
| * Validates address against white list | ||
| * | ||
| * @param _address Address to check |
bweick
reviewed
Jan 7, 2019
| /** | ||
| * Verifies an array of addresses against the whitelist | ||
| * | ||
| * @return address[] Array of addresses to verify |
bweick
reviewed
Jan 7, 2019
contracts/lib/WhiteList.sol
Outdated
| /** | ||
| * Verifies an array of addresses against the whitelist | ||
| * | ||
| * @return address[] Array of addresses to verify |
Contributor
There was a problem hiding this comment.
should be param and add a return javadoc
felix2feng
approved these changes
Jan 7, 2019
contracts/lib/WhiteList.sol
Outdated
| /** | ||
| * Verifies an array of addresses against the whitelist | ||
| * | ||
| * @return address[] Array of addresses to verify |
asoong
force-pushed
the
alex/implement_whitelist_for_propose
branch
from
a7882af to
e1b88ea
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.