Skip to content
This repository was archived by the owner on Jan 18, 2023. It is now read-only.

Conversation

@felix2feng
Copy link
Contributor

Move SignatureValidator from Core to CoreIssuanceModule as the validator is only used there.

@felix2feng felix2feng requested review from asoong and bweick January 11, 2019 21:38
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3623

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 3606: 0.0%
Covered Lines: 769
Relevant Lines: 769

💛 - Coveralls

Copy link
Contributor

@asoong asoong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight forward, LGTM

@felix2feng felix2feng merged commit 229db0c into master Jan 13, 2019
@felix2feng felix2feng deleted the felix/move-signature-validator-to-issuance branch January 13, 2019 21:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants