This repository was archived by the owner on Jan 18, 2023. It is now read-only.
Add in fixes for the test setup in Vault specs so that subject() prop… #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asoong
force-pushed
the
justin-chen_fix_vault-specs
branch
from
4b0e0d2 to
fe92733
Compare
…erly works in scope. Also brings test coverage up to 100%
asoong
force-pushed
the
justin-chen_fix_vault-specs
branch
from
fe92733 to
616c916
Compare
asoong
approved these changes
Jun 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…erly works in scope. Also brings test coverage up to 100% for Vault.
Keep in mind this ordering: https://gist.github.com/harto/c97d2fc9d0bfaf20706eb2acbf48c908
@SetProtocol/set-protocol-core