Sort input file list #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that fastnumbers.so builds in a reproducible way in spite of indeterministic filesystem readdir order and http://bugs.python.org/issue30461 See https://reproducible-builds.org/ for why this is good.
Codecov Report
@@ Coverage Diff @@
## master #12 +/- ##
=======================================
Coverage 92.45% 92.45%
=======================================
Files 17 17
Lines 848 848
Branches 129 129
=======================================
Hits 784 784
Misses 31 31
Partials 33 33Continue to review full report at Codecov.
|
|
It’s disappointing that this is even a problem. Thanks for the PR. I’ll get to it when I am back in front of a computer. Is this something you think should require a new release? |
|
it is not urgent, but it would be nice, if it becomes part of a new release before 2019. The whole reproducible builds work is a long-term effort - I'm usually thinking of 2025 as a target. |
|
This will be released with version 2.0.5. I plan to release by the end of June. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Sort input file list
so that fastnumbers.so builds in a reproducible way
in spite of indeterministic filesystem readdir order
and http://bugs.python.org/issue30461
See https://reproducible-builds.org/ for why this is good.
Without this patch, the python-fastnumbers package in openSUSE differed for every build (that happens in a disposable VM).