Skip to content

Conversation

@AnimatedSwine37
Copy link
Contributor

This pr does the following:

  • Updates the Atlus Script Tools module to use the main repo instead of my fork. (This Commit)
    • Includes a bunch of miscellaneous bug fixes
    • Includes updated charsets for P3P, P4G, and P5R to allow support for every language
  • Added a SetEncoding function to the BF and BMD Emulator APIs that lets the Encoding used by Script Compiler be changed
  • Added a TryGetImports function to the BF Emulator API that reports all files that will be used to compile a bf
  • Changed BF Emulator's library overrides so they now add the new function name as an alias instead of completely overriding. This allows multiple mods to override the same function (if they are just renaming it)
  • Added support for Emulating file last write time.
    • This is currently only implemented in BF and BMD Emulators.
  • Fixed Incorrect file length reported by QueryFullAttributesFile #15 so the size (and last write time) of files can be emulated before a handle to them is created
  • Added checks for empty files in PAK Emulator. These are now ignored, with an error logged, instead of causing a crash. Typically this is due to an error emulating a file in the PAK like a BF or BMD.
  • Added error handling around BF and BMD compilation to prevent crashes, giving logged errors instead.

Sorry to put so much in one pr but I didn't think it was worth trying to split it up after I'd gotten to this point :p

Copy link
Owner

@Sewer56 Sewer56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to trust that you didn't mess up, since I know you do a good job :p
I lack the resources for a proper dig through right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect file length reported by QueryFullAttributesFile

2 participants