Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Real file path and allow to refresh image gallery #6

Merged
merged 8 commits into from Sep 7, 2018

Conversation

Projects
None yet
2 participants
@CircleCurve
Copy link
Contributor

commented Sep 7, 2018

Fixed some image picker would not refresh gallery when capture or save the new image. And also, identifier only get the path which is content://....etc . And one more option to allow real path

@Sh1d0w
Copy link
Owner

left a comment

Hi, and thanks for your contribution. Changes seem ok, could you only remove some of the commented out code you have left, and then it will be good to merge.

Show resolved Hide resolved example/pubspec.yaml Outdated
@@ -54,6 +54,7 @@ class _MyAppState extends State<MyApp> {

setState(() {
images = resultList;
// print(images[0].filePath) ;

This comment has been minimized.

Copy link
@Sh1d0w

Sh1d0w Sep 7, 2018

Owner

Can you please remove this.

}

/*
private void refreshGallery(final MultiImagePickerPlugin.Refresh refresh) {

This comment has been minimized.

Copy link
@Sh1d0w

Sh1d0w Sep 7, 2018

Owner

Can you please remove this if not needed.

.choose(MimeType.ofImage())
.countable(true)
.maxSelectable(maxImages)
.restrictOrientation(ActivityInfo.SCREEN_ORIENTATION_UNSPECIFIED)
.imageEngine(new GlideEngine())
.forResult(REQUEST_CODE_CHOOSE);

/*
this.refreshGallery(new Refresh() {

This comment has been minimized.

Copy link
@Sh1d0w

Sh1d0w Sep 7, 2018

Owner

Can you please remove this if not needed.

import android.media.ThumbnailUtils;
import android.net.Uri;

import com.zhihu.matisse.Matisse;
import com.zhihu.matisse.MimeType;
import com.zhihu.matisse.engine.impl.GlideEngine;
import com.zhihu.matisse.internal.entity.CaptureStrategy;

This comment has been minimized.

Copy link
@Sh1d0w

Sh1d0w Sep 7, 2018

Owner

Do we need this import?

@@ -0,0 +1 @@
multi_image_picker

This comment has been minimized.

Copy link
@Sh1d0w

Sh1d0w Sep 7, 2018

Owner

Can you please add the whole .idea folder to .gitignore and remove it from this commit. We don't need it to be in the repository.

patrick patrick
Remove the unrelated directore (idea)
Remove unrelated comment code
Add gitignore
@CircleCurve

This comment has been minimized.

Copy link
Contributor Author

commented Sep 7, 2018

I have remove an unrelated comment code and add .idea in .gitignore file. Thanks for your kindly help

@Sh1d0w Sh1d0w merged commit 0289537 into Sh1d0w:master Sep 7, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Sh1d0w

This comment has been minimized.

Copy link
Owner

commented Sep 7, 2018

The PR has been merged and I've pushed new release 2.1.25, which now can be installed.

Thanks!

@kimhan kimhan referenced this pull request Jan 23, 2019

Closed

exif #67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.