Skip to content

Feature / Transition between two card swapping position in template - #58

Merged
ShaanCoding merged 3 commits into
ShaanCoding:developfrom
MathPow:feature/transition-swap-block
Apr 26, 2024
Merged

Feature / Transition between two card swapping position in template#58
ShaanCoding merged 3 commits into
ShaanCoding:developfrom
MathPow:feature/transition-swap-block

Conversation

@MathPow

@MathPow MathPow commented Apr 26, 2024

Copy link
Copy Markdown
Contributor

feat: transition between two card changing position

This video should say it all :)

[Video](https://drive.google.com/file/d/18BYq2L9ttCd1FrHAgRTmncxqtmroiPtz/view?usp=sharing)

@ShaanCoding
ShaanCoding changed the base branch from main to develop April 26, 2024 02:12
@ShaanCoding

Copy link
Copy Markdown
Owner

Wow! Looks super clean! Love how this 'small' change has made the app look significantly more polished!

I've just updated the types to fix the broken build, would you mind resolving these conflicts if possible, otherwise I'll do these myself in 5-6 hours and merge it in! Thanks again!

@ShaanCoding
ShaanCoding force-pushed the feature/transition-swap-block branch from 225fbe4 to 13c2043 Compare April 26, 2024 09:32
@ShaanCoding

Copy link
Copy Markdown
Owner

I've rebased this branch with the latest version of develop. As a FYI when raising PRs please set the branch source to develop and not main as it'll pass through this branch first before being merged through.

All looks good & I'm happy with the changes, I'm just going to remove the cursor-pointer attribute on the field as at the current moment this entire block is not clickable / draggable around. This functionality should be implemented in #50, where you can re-add the cursor-pointer attribute

- Removed cursor-pointer as currently it's not interactable
@ShaanCoding
ShaanCoding merged commit 4a9034d into ShaanCoding:develop Apr 26, 2024
ShaanCoding added a commit that referenced this pull request Apr 27, 2024
)

* feat: transition between two card changing position

* Handled Merge Conflict

* Removed cursor-pointer

- Removed cursor-pointer as currently it's not interactable

---------

Co-authored-by: Shaan <22236218+ShaanCoding@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants