Add file IO error handling in controllers & minor refactor - #96
Merged
ShaanCoding merged 1 commit intoMay 7, 2024
Merged
Conversation
aminbeigi
commented
May 7, 2024
aminbeigi
commented
Contributor
- Add file IO error handling in controllers.
- Minor refactor reducing duplicated code.
ShaanCoding
approved these changes
May 7, 2024
ShaanCoding
left a comment
ShaanCoding
left a comment
Owner
There was a problem hiding this comment.
LGTM, thanks for the refactor - For context in #87 I'm planning to replace FS with MongoDB for the most part, so the FS stuff here has been hacked together, but it's good to remove a lot of the anti-patterns here regardless.
Thanks for the PR!
ShaanCoding
added a commit
that referenced
this pull request
May 7, 2024
[Release] UI Enhancements & Backend Refactor Summary - "Page Type" buttons break easily #94 - Add file IO error handling in controllers & minor refactor #96 - [Shaan] Added Framer Motion Animations To Landing Page #97 Credits - @ShaanCoding - @MathPow - @aminbeigi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.