Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPUnit - mcrypt deprecated since php >= 7.1 so skip test #272

Merged
merged 13 commits into from
Nov 12, 2022
Merged

PHPUnit - mcrypt deprecated since php >= 7.1 so skip test #272

merged 13 commits into from
Nov 12, 2022

Conversation

hungtrinh
Copy link

@hungtrinh hungtrinh commented Nov 10, 2022 •
edited
Loading

@hungtrinh
phpunit - Skip test use method mcrypt_* on php >= 7.1
e38c3bb 
mcrypt_* function has been DEPRECATED as of PHP 7.1.0 and REMOVED as of PHP 7.2.0. Relying on this function is highly discouraged.
@hungtrinh
phpunit - skip run Openssl test on php >= 8.0
040561c 
since php 8.0 will raise something like that 'ArgumentCountError: openssl_seal() expects at least 5 arguments, 4 given'
@hungtrinh
phpunit - ignore temp file make by test
070460c
@hungtrinh hungtrinh marked this pull request as ready for review November 10, 2022 18:31
@Jimbolino
Copy link
Collaborator

Great work 👍
If you change "depricated" to "deprecated", i'm ok for merging it :)

@hungtrinh hungtrinh changed the title PHPUnit - mcrypt deprecation since php >= 7.1 so skip test PHPUnit - mcrypt deprecated since php >= 7.1 so skip test Nov 12, 2022
@hungtrinh
Copy link
Author

It's done @Jimbolino :)

@Jimbolino Jimbolino merged commit 0d4c5dc into Shardj:master Nov 12, 2022
@hungtrinh
Copy link
Author

Great work 👍
If you change "depricated" to "deprecated", i'm ok for merging it :)

@Jimbolino sorry, I thought you mentioned about typo in the commit message ^^

So i fix typo in commit message only :p

@hungtrinh hungtrinh deleted the phpunit-mcrypt-deprecation branch March 7, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHPUnit tests - unwanted files created, not gitignored PHPUnit testing - mcrypt deprecation notices
2 participants
@hungtrinh @Jimbolino