New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double URI encode for extra OAuth parameters. #515

Merged
merged 1 commit into from Sep 17, 2012

Conversation

Projects
None yet
2 participants
@kishikawakatsumi
Contributor

kishikawakatsumi commented Sep 16, 2012

Fix double URI encode for extra OAuth parameters.
If set extra oauth parameters, for instance oath_calback, it makes signature invalid.Because of the each keys and values are encoded twice.
e.g. oauth_calback=http%253A%252F%252Fwww.example.com
fixed: oauth_calback=http%3A%2F%2Fwww.example.com

@VilemKurz

This comment has been minimized.

Show comment
Hide comment
@VilemKurz

VilemKurz Sep 16, 2012

Contributor

Have you tested it with all sharers which use extra OAuth parameters?

Contributor

VilemKurz commented Sep 16, 2012

Have you tested it with all sharers which use extra OAuth parameters?

VilemKurz added a commit that referenced this pull request Sep 17, 2012

Merge pull request #515 from kishikawakatsumi/bugfix-oaconsumer
Fix double URI encode for extra OAuth parameters.

@VilemKurz VilemKurz merged commit d55ed00 into ShareKit:master Sep 17, 2012

@VilemKurz VilemKurz referenced this pull request Sep 17, 2012

Closed

Various bug fixes #455

@kishikawakatsumi

This comment has been minimized.

Show comment
Hide comment
@kishikawakatsumi

kishikawakatsumi Sep 18, 2012

Contributor

Have you tested it with all sharers which use extra OAuth parameters?

There is one sharer that use extra OAuth parameter, SHKLinkedIn. SHKLinkedIn use custom sub class called SHKLinkedInOAMutableURLRequest.
So this change makes no affect other sharers.

Contributor

kishikawakatsumi commented Sep 18, 2012

Have you tested it with all sharers which use extra OAuth parameters?

There is one sharer that use extra OAuth parameter, SHKLinkedIn. SHKLinkedIn use custom sub class called SHKLinkedInOAMutableURLRequest.
So this change makes no affect other sharers.

@VilemKurz

This comment has been minimized.

Show comment
Hide comment
@VilemKurz

VilemKurz Sep 18, 2012

Contributor

Yeah, I noticed it yesterday. In fact, I have also simplified SHKLinkedIn to use standard OAMutableURLRequest, and tested it.

Contributor

VilemKurz commented Sep 18, 2012

Yeah, I noticed it yesterday. In fact, I have also simplified SHKLinkedIn to use standard OAMutableURLRequest, and tested it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment