New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hatena Bookmark Sharer. #521

Merged
merged 4 commits into from Mar 9, 2013

Conversation

Projects
None yet
2 participants
@kishikawakatsumi
Contributor

kishikawakatsumi commented Sep 18, 2012

Add Hatena Bookmark Sharer. 'Hatena Bookmark' is the most popular social bookmark service in japanese like delicious. The official URL is http://b.hatena.ne.jp/ .

To use this sharer, get OAuth keys from developer site, http://developer.hatena.ne.jp/en , and fill these keys to SHKHatenaConsumerKey and SHKHatenaSecretKey macro.

@VilemKurz

View changes

Show outdated Hide outdated Classes/ShareKit/Sharers/Services/Hatena/SHKHatena.m
- (void)tokenRequestModifyRequest:(OAMutableURLRequest *)oRequest
{
[oRequest setOAuthParameterName:@"oauth_callback" withValue:SHKHatenaCallbackUrl];
oRequest.parameters = @[[OARequestParameter requestParameterWithName:@"scope" value:@"write_public,write_private"]];

This comment has been minimized.

@VilemKurz

VilemKurz Sep 21, 2012

Contributor

why do not you use supplied setOAuthParameterName:withValue method?

@VilemKurz

VilemKurz Sep 21, 2012

Contributor

why do not you use supplied setOAuthParameterName:withValue method?

This comment has been minimized.

@kishikawakatsumi

kishikawakatsumi Oct 4, 2012

Contributor

'scope' is not OAuth parameter. If it is added as OAuth parameter, makes authentication failed.

@kishikawakatsumi

kishikawakatsumi Oct 4, 2012

Contributor

'scope' is not OAuth parameter. If it is added as OAuth parameter, makes authentication failed.

- (void)tokenRequestModifyRequest:(OAMutableURLRequest *)oRequest
{
[oRequest setOAuthParameterName:@"oauth_callback" withValue:SHKHatenaCallbackUrl];

This comment has been minimized.

@VilemKurz

VilemKurz Sep 21, 2012

Contributor

is this really needed, or is it only copied from some other sharer?

@VilemKurz

VilemKurz Sep 21, 2012

Contributor

is this really needed, or is it only copied from some other sharer?

This comment has been minimized.

@kishikawakatsumi

kishikawakatsumi Oct 4, 2012

Contributor

Hatena's OAuth always require 'oauth_callback' parameter. If missing it, OAuth failed.
Also if set 'oob' for 'oauth_callback' parameter, it changed PIN based authentication.
The PIN code that Hatena OAuth provided is complicated. It is difficult to input by mobile keyboard.

@kishikawakatsumi

kishikawakatsumi Oct 4, 2012

Contributor

Hatena's OAuth always require 'oauth_callback' parameter. If missing it, OAuth failed.
Also if set 'oob' for 'oauth_callback' parameter, it changed PIN based authentication.
The PIN code that Hatena OAuth provided is complicated. It is difficult to input by mobile keyboard.

@VilemKurz

View changes

Show outdated Hide outdated Classes/ShareKit/Sharers/Services/Hatena/SHKHatena.m
@VilemKurz

View changes

Show outdated Hide outdated Submodules/evernote-ios-sdk

@VilemKurz VilemKurz merged commit 7e2d3c4 into ShareKit:master Mar 9, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment