This repository has been archived by the owner. It is now read-only.

config.hasOwnProperty check "spFXContext" string replaced by "spfxContext" #419

Merged
merged 1 commit into from Apr 18, 2017

Conversation

Projects
None yet
3 participants
@VelinGeorgiev
Contributor

VelinGeorgiev commented Apr 18, 2017

The upper letters "FX" in config.hasOwnProperty("spFXContext ") check in file src/configuration/pnplibconfig.ts were the reason the pnp.setup not to pick the custom spfxContext for spfx webpart.

Q A
Bug fix? [X ]
New feature? [ ]
New sample? [ ]
Related issues? fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?

Small bug fix related to issue #411

spFXContext string replaced by spfxContext
Small bug fix related to issue #411
The upper letters "FX" in config.hasOwnProperty("spFXContext ") check were the reason the pnp.setup not to pick the custom spfxContext for a spfx webpart.
@msftclas

This comment has been minimized.

Show comment
Hide comment
@msftclas

msftclas Apr 18, 2017

@VelinGeorgiev,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

msftclas commented Apr 18, 2017

@VelinGeorgiev,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@patrick-rodgers patrick-rodgers merged commit d7a066a into SharePoint:dev Apr 18, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@patrick-rodgers

This comment has been minimized.

Show comment
Hide comment
@patrick-rodgers

patrick-rodgers Apr 18, 2017

Contributor

Great find, thanks for the fix!

Contributor

patrick-rodgers commented Apr 18, 2017

Great find, thanks for the fix!

@patrick-rodgers patrick-rodgers added this to the 2.0.5 milestone Apr 22, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.