New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring TaxonomyPicker sample and Component in sync #738

Merged
merged 1 commit into from Apr 30, 2015

Conversation

Projects
None yet
3 participants
@pbjorklund
Copy link
Contributor

pbjorklund commented Apr 28, 2015

Update sample and component to be in sync. In order to do
this I reimplemented the Samples functionality to accept
context, callbacks, LevelToShowTerms and Filter.

There is an option in the sample to use term as root node which
I did not reimplement, I don't really see the point of it and
it's not really trivial to do.

I did not update the README's of the projects, it warrants
a discussion of why there are two (now in sync) things in PnP
that does the same thing. Why not remove the sample?

Bring TaxonomyPicker sample and Component in sync
Update sample and component to be in sync. In order to do
this I reimplemented the Samples functionality to accept
context, callbacks, LevelToShowTerms and Filter.

There is an option in the sample to use term as root node which
I did not reimplement, I don't really see the point of it and
it's not really trivial to do.

I did not update the README's of the projects, it warrants
a discussion of why there are two (now in sync) things in PnP
that does the same thing. Why not remove the sample?
@jansenbe

This comment has been minimized.

Copy link
Contributor

jansenbe commented Apr 29, 2015

Thx Patrick. Will process this one today

@jansenbe

This comment has been minimized.

Copy link
Contributor

jansenbe commented Apr 29, 2015

Have been investigating and seems there's a slight difference between this one and the component one. This version supports filtering of terms and supports to only show certain level in a hierarchical termset. These capabilities are not in the component version.

Ideal scenario is:
*/ take over these capabilities to component version
*/ Update the documentation of the component version to highlight this capability
*/ Drop the sample

To get a clean view on what was added to implement the filtering and hierarchical support you can check history of both files, get their initial commit version and compare them.

Do you want to take this Patrick?

@pbjorklund

This comment has been minimized.

Copy link
Contributor Author

pbjorklund commented Apr 29, 2015

They are in the component version as well now. This PR update both sample and component

@jansenbe jansenbe merged commit 145357d into SharePoint:dev Apr 30, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment